Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: net/quic/core/quic_connection.cc

Issue 2706893002: Make QuicFramer unaware of path. Also, send/receive PathClose has no effect. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_connection.h ('k') | net/quic/core/quic_connection_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_connection.cc
diff --git a/net/quic/core/quic_connection.cc b/net/quic/core/quic_connection.cc
index 56e8c33e2625320e96c2d93321d5a6e00cc8e146..7bb88eee08e0f31904453e1e4df855d6528a7b99 100644
--- a/net/quic/core/quic_connection.cc
+++ b/net/quic/core/quic_connection.cc
@@ -908,7 +908,6 @@ bool QuicConnection::OnPathCloseFrame(const QuicPathCloseFrame& frame) {
}
QUIC_DLOG(INFO) << ENDPOINT
<< "PATH_CLOSE_FRAME received for path: " << frame.path_id;
- OnPathClosed(frame.path_id);
return connected_;
}
@@ -1144,7 +1143,6 @@ void QuicConnection::SendPathClose(QuicPathId path_id) {
// Opportunistically bundle an ack with this outgoing packet.
ScopedPacketBundler ack_bundler(this, SEND_ACK_IF_PENDING);
packet_generator_.AddControlFrame(QuicFrame(new QuicPathCloseFrame(path_id)));
- OnPathClosed(path_id);
}
const QuicConnectionStats& QuicConnection::GetStats() {
@@ -2337,11 +2335,6 @@ void QuicConnection::StartPeerMigration(
sent_packet_manager_.OnConnectionMigration(peer_migration_type);
}
-void QuicConnection::OnPathClosed(QuicPathId path_id) {
- // Stop receiving packets on this path.
- framer_.OnPathClosed(path_id);
-}
-
bool QuicConnection::ack_frame_updated() const {
return received_packet_manager_.ack_frame_updated();
}
« no previous file with comments | « net/quic/core/quic_connection.h ('k') | net/quic/core/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698