Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2706883002: Add missing charset tag to html resources (Closed)

Created:
3 years, 10 months ago by Jinsuk Kim
Modified:
3 years, 10 months ago
Reviewers:
Bernhard Bauer, sky
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing charset tag to html resources I18N-resource html files should have an explicit charset tag specificying their encoding in accordance with the recent changes that do not auto-detect UTF-8 encoding. See https://crrev.com/2697213002 BUG=694127 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2706883002 Cr-Commit-Position: refs/heads/master@{#451843} Committed: https://chromium.googlesource.com/chromium/src/+/e2221203908694ce026c037e9d084485a1f92c81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/welcome/welcome.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/welcome/win10/inline.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/welcome/win10/sectioned.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Jinsuk Kim
3 years, 10 months ago (2017-02-21 01:55:19 UTC) #5
Jinsuk Kim
3 years, 10 months ago (2017-02-21 13:53:19 UTC) #9
Bernhard Bauer
lgtm
3 years, 10 months ago (2017-02-21 13:54:18 UTC) #11
sky
LGTM
3 years, 10 months ago (2017-02-21 18:25:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706883002/1
3 years, 10 months ago (2017-02-21 19:24:44 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-21 21:29:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706883002/1
3 years, 10 months ago (2017-02-21 21:33:05 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 21:57:31 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e2221203908694ce026c037e9d08...

Powered by Google App Engine
This is Rietveld 408576698