Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2706833002: [regexp] Fix smi receiver in stack accessors (Closed)

Created:
3 years, 10 months ago by jgruber
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Michael Starzinger
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix smi receiver in stack accessors info.This returns a Local<Object>, which results in a call to Utils::OpenHandle<JSReceiver>. Casting to a Local<Value> first uses the correct OpenHandle<Object> overload. BUG=chromium:693500 Review-Url: https://codereview.chromium.org/2706833002 Cr-Commit-Position: refs/heads/master@{#43314} Committed: https://chromium.googlesource.com/v8/v8/+/3acc00a0176af5d36f251cd993f49e5db938553f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/accessors.cc View 2 chunks +4 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-693500.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jgruber
3 years, 10 months ago (2017-02-20 11:25:19 UTC) #6
Yang
lgtm
3 years, 10 months ago (2017-02-20 11:44:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706833002/1
3 years, 10 months ago (2017-02-20 11:46:53 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 11:48:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3acc00a0176af5d36f251cd993f49e5db93...

Powered by Google App Engine
This is Rietveld 408576698