CHECK correct context usage in V8ScriptRunner::callFunction

third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "bindings/core/v8/V8ErrorHandler.h"
 
 #include "bindings/core/v8/ScriptController.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8ErrorEvent.h"
 #include "bindings/core/v8/V8PrivateProperty.h"
 #include "bindings/core/v8/V8ScriptRunner.h"
+#include "core/dom/Document.h"
 #include "core/dom/ExecutionContext.h"
 
 namespace blink {
 
 V8ErrorHandler::V8ErrorHandler(bool isInline, ScriptState* scriptState)
     : V8EventListener(isInline, scriptState) {}
 
 v8::Local<v8::Value> V8ErrorHandler::callListenerFunction(
     ScriptState* scriptState,
     v8::Local<v8::Value> jsEvent,
@@ skipping 30 matching lines @@
       v8::Integer::New(isolate(), errorEvent->lineno()),
       v8::Integer::New(isolate(), errorEvent->colno()), error};
   v8::TryCatch tryCatch(isolate());
   tryCatch.SetVerbose(true);
   v8::MaybeLocal<v8::Value> result;
   if (scriptState->getExecutionContext()->isWorkerGlobalScope()) {
     result = V8ScriptRunner::callFunction(
         callFunction, scriptState->getExecutionContext(), thisValue,
         WTF_ARRAY_LENGTH(parameters), parameters, isolate());
   } else {
+    LocalFrame* frame = toDocument(scriptState->getExecutionContext())->frame();
+    if (frame && world().isMainWorld()) {
+      CHECK(BindingSecurity::shouldAllowAccessToFrame(
+          toDOMWindow(callFunction->CreationContext())->toLocalDOMWindow(),

[dcheng, 2017/02/20 10:07:42]

Hmm... I guess I should fix this to return a LocalDOMWindow.

+          frame, BindingSecurity::ErrorReportOption::DoNotReport));
+    }
+
     result = V8ScriptRunner::callFunction(
         callFunction, scriptState->getExecutionContext(), thisValue,
         WTF_ARRAY_LENGTH(parameters), parameters, isolate());
   }
   v8::Local<v8::Value> returnValue;
   if (!result.ToLocal(&returnValue))
     return v8::Null(isolate());
 
   return returnValue;
 }
@@ skipping 33 matching lines @@
   if (error->IsUndefined())
     return v8::Local<v8::Value>();
   return error;
 }
 
 bool V8ErrorHandler::shouldPreventDefault(v8::Local<v8::Value> returnValue) {
   return returnValue->IsBoolean() && returnValue.As<v8::Boolean>()->Value();
 }
 
 }  // namespace blink