CHECK correct context usage in V8ScriptRunner::callFunction

CHECK correct context usage in V8ScriptRunner::callFunction

Not tests, since it shouldn't be possible to reach that.

BUG=693695
R=dcheng@chromium.org,haraken@chromium.org

Review-Url: https://codereview.chromium.org/2706813002
Cr-Commit-Position: refs/heads/master@{#451622}
Committed: https://chromium.googlesource.com/chromium/src/+/5cde67543e5c89f1f9da84e1ae860c30283dee3c

[jochen (gone - plz use gerrit), 2017-02-20 09:52:04]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 09:52:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-20 10:01:55]

LGTM

https://codereview.chromium.org/2706813002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp (right):

https://codereview.chromium.org/2706813002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp:114: frame,
BindingSecurity::ErrorReportOption::DoNotReport));

Another idea would be to move the CHECK into V8ScriptRunner::callFunction?

[dcheng, 2017-02-20 10:07:42]

LGTM

https://codereview.chromium.org/2706813002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp (right):

https://codereview.chromium.org/2706813002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp:92:
toDOMWindow(callFunction->CreationContext())->toLocalDOMWindow(),
Hmm... I guess I should fix this to return a LocalDOMWindow.

[commit-bot: I haz the power, 2017-02-20 11:25:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 11:25:10]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-02-20 12:22:49]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[jochen (gone - plz use gerrit), 2017-02-20 12:23:11]

new approach (will update the CL description), ptal

[commit-bot: I haz the power, 2017-02-20 12:23:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-20 12:23:56]

LGTM

[jochen (gone - plz use gerrit), 2017-02-20 13:01:36]

Description was changed from

==========
Sprinkle some CHECKs about correct context usage over event listeners

Not tests, since it shouldn't be possible to reach them.

BUG=693695
R=dcheng@chromium.org,haraken@chromium.org
==========

to

==========
CHECK correct context usage in V8ScriptRunner::callFunction

Not tests, since it shouldn't be possible to reach that.

BUG=693695
R=dcheng@chromium.org,haraken@chromium.org
==========

[jochen (gone - plz use gerrit), 2017-02-20 13:43:40]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-02-20 13:43:43]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-02-20 13:43:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2706813002/#ps20001
(title: "updates")

[commit-bot: I haz the power, 2017-02-20 13:44:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 14:24:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487598223405950,
"parent_rev": "abf0ba6a507ee0eb418f49829a23caeb29778fd0", "commit_rev":
"5cde67543e5c89f1f9da84e1ae860c30283dee3c"}

[commit-bot: I haz the power, 2017-02-20 14:25:12]

Description was changed from

==========
CHECK correct context usage in V8ScriptRunner::callFunction

Not tests, since it shouldn't be possible to reach that.

BUG=693695
R=dcheng@chromium.org,haraken@chromium.org
==========

to

==========
CHECK correct context usage in V8ScriptRunner::callFunction

Not tests, since it shouldn't be possible to reach that.

BUG=693695
R=dcheng@chromium.org,haraken@chromium.org

Review-Url: https://codereview.chromium.org/2706813002
Cr-Commit-Position: refs/heads/master@{#451622}
Committed:
https://chromium.googlesource.com/chromium/src/+/5cde67543e5c89f1f9da84e1ae86...
==========

[commit-bot: I haz the power, 2017-02-20 14:25:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5cde67543e5c89f1f9da84e1ae86...

[esprehn, 2017-02-21 23:37:12]

This is adding even more overhead to custom element callbacks and other callback
APIs, can we make this a DCHECK? This alone is adding a dozen branches and many
nested function calls to every call into JS from blink.