Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2706763003: [compiler] Refine typing of NumberShiftRightLogical. (Closed)

Created:
3 years, 10 months ago by neis
Modified:
3 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Refine typing of NumberShiftRightLogical. Use the type of the RHS to compute a more precise output type. In particular, if the RHS is, say, 1, we now know that the result is a subtype of Unsigned31. R=jarin@chromium.org BUG= Review-Url: https://codereview.chromium.org/2706763003 Cr-Commit-Position: refs/heads/master@{#43340} Committed: https://chromium.googlesource.com/v8/v8/+/b0c7a0fc6d0417eee2e55a392133bd2e88341cb0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M src/compiler/operation-typer.cc View 1 chunk +20 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
neis
3 years, 10 months ago (2017-02-20 09:04:11 UTC) #1
Jarin
lgtm
3 years, 10 months ago (2017-02-21 09:25:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706763003/1
3 years, 10 months ago (2017-02-21 09:26:57 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 09:48:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b0c7a0fc6d0417eee2e55a392133bd2e883...

Powered by Google App Engine
This is Rietveld 408576698