Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2706693003:
AutoRebaseline Layout tests suppressed for Skia roll (Closed)
|
Created:
3 years, 10 months ago by robertphillips Modified:
3 years, 10 months ago CC:
chromium-reviews, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAutoRebaseline Layout tests suppressed for Skia roll
The Skia CL that caused the layout test changes (https://skia-review.googlesource.com/c/8701/ (Replace SkSpecialImage::makeTightSubset with asImage (take 2))) has landed in Skia
and rolled into Chrome (https://codereview.chromium.org/2704913003) at r451504.
TBR=fmalita@chromium.org
BUG=693510
Review-Url: https://codereview.chromium.org/2706693003
Cr-Commit-Position: refs/heads/master@{#451528}
Committed: https://chromium.googlesource.com/chromium/src/+/da6bb130906d829798ade6529aecbf05cca19efa
Patch Set 1 #
Messages
Total messages: 19 (13 generated)
Description was changed from ========== AutoRebaseline Layout tests suppressed for Skia roll The Skia CL that caused the layout test changes () has landed in Skia and rolled into Chrome. BUG=693510 ========== to ========== AutoRebaseline Layout tests suppressed for Skia roll The Skia CL that caused the layout test changes (https://skia-review.googlesource.com/c/8701/ (Replace SkSpecialImage::makeTightSubset with asImage (take 2))) has landed in Skia and rolled into Chrome. BUG=693510 ==========
robertphillips@google.com changed reviewers: + fmalita@chromium.org, reed@chromium.org, reed@google.com
Description was changed from ========== AutoRebaseline Layout tests suppressed for Skia roll The Skia CL that caused the layout test changes (https://skia-review.googlesource.com/c/8701/ (Replace SkSpecialImage::makeTightSubset with asImage (take 2))) has landed in Skia and rolled into Chrome. BUG=693510 ========== to ========== AutoRebaseline Layout tests suppressed for Skia roll The Skia CL that caused the layout test changes (https://skia-review.googlesource.com/c/8701/ (Replace SkSpecialImage::makeTightSubset with asImage (take 2))) has landed in Skia and rolled into Chrome (https://codereview.chromium.org/2704913003) at r451504. BUG=693510 ==========
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== AutoRebaseline Layout tests suppressed for Skia roll The Skia CL that caused the layout test changes (https://skia-review.googlesource.com/c/8701/ (Replace SkSpecialImage::makeTightSubset with asImage (take 2))) has landed in Skia and rolled into Chrome (https://codereview.chromium.org/2704913003) at r451504. BUG=693510 ========== to ========== AutoRebaseline Layout tests suppressed for Skia roll The Skia CL that caused the layout test changes (https://skia-review.googlesource.com/c/8701/ (Replace SkSpecialImage::makeTightSubset with asImage (take 2))) has landed in Skia and rolled into Chrome (https://codereview.chromium.org/2704913003) at r451504. TBR=fmalita@chromium.org BUG=693510 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by fmalita@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487543140711490, "parent_rev":
"97c2faae478f944add1951dc0cdcb5556e1d60b4", "commit_rev":
"da6bb130906d829798ade6529aecbf05cca19efa"}
Message was sent while issue was closed.
Description was changed from ========== AutoRebaseline Layout tests suppressed for Skia roll The Skia CL that caused the layout test changes (https://skia-review.googlesource.com/c/8701/ (Replace SkSpecialImage::makeTightSubset with asImage (take 2))) has landed in Skia and rolled into Chrome (https://codereview.chromium.org/2704913003) at r451504. TBR=fmalita@chromium.org BUG=693510 ========== to ========== AutoRebaseline Layout tests suppressed for Skia roll The Skia CL that caused the layout test changes (https://skia-review.googlesource.com/c/8701/ (Replace SkSpecialImage::makeTightSubset with asImage (take 2))) has landed in Skia and rolled into Chrome (https://codereview.chromium.org/2704913003) at r451504. TBR=fmalita@chromium.org BUG=693510 Review-Url: https://codereview.chromium.org/2706693003 Cr-Commit-Position: refs/heads/master@{#451528} Committed: https://chromium.googlesource.com/chromium/src/+/da6bb130906d829798ade6529aec... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/da6bb130906d829798ade6529aec... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
