Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 2706693002: Revert of Unskip more tests that are no longer flaky (Closed)

Created:
3 years, 10 months ago by rhogan
Modified:
3 years, 10 months ago
Reviewers:
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Unskip more tests that are no longer flaky (patchset #2 id:20001 of https://codereview.chromium.org/2704023002/ ) Reason for revert: text-overflow-ellipsis-button.html still fails on Mac Original issue's description: > Unskip more tests that are no longer flaky > > Follow up to https://codereview.chromium.org/2686693002, these tests should > no longer be flaky. > > TBR=eae@chromium.org > > BUG=663855 > > Review-Url: https://codereview.chromium.org/2704023002 > Cr-Commit-Position: refs/heads/master@{#451486} > Committed: https://chromium.googlesource.com/chromium/src/+/f0d8d6ac72c8c8e0bf7447abe2ba455caf12d8cf TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=663855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rhogan
Created Revert of Unskip more tests that are no longer flaky
3 years, 10 months ago (2017-02-19 11:36:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706693002/1
3 years, 10 months ago (2017-02-19 11:36:46 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-19 11:37:19 UTC) #5
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:1727
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
8af3204ee35890bdcf20c8452a1d9af2eec68bb2..13a38331de55f9623d062d80e577a91f63dafd7e
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -845,6 +845,8 @@
 crbug.com/638693 virtual/threaded/animations/display-inline-style-adjust.html [
Pass Crash Failure ]
 crbug.com/421283 html/marquee/marquee-scrollamount.html [ Pass Failure ]
 
+crbug.com/659123 [ Mac ] fast/css/text-overflow-ellipsis-button.html [ Pass
Failure ]
+
 # TODO(oshima): Mac Android are currently not supported.
 crbug.com/567837 [ Mac Android ]
virtual/scalefactor200withzoom/fast/hidpi/static [ Skip ]
 
@@ -1727,7 +1729,7 @@
 crbug.com/572723 inspector/sources/debugger/debugger-disable-enable.html [ Pass
Failure Timeout ]
 crbug.com/572723
inspector/sources/debugger/debugger-uncaught-promise-on-pause.html [ Timeout
Pass ]
 
-crbug.com/155836 fast/text/emphasis-ellipsis-complextext.html [ NeedsRebaseline
]
+crbug.com/155836 fast/text/emphasis-ellipsis-complextext.html [ Failure Pass ]
 
 crbug.com/577380 [ Linux Debug ]
http/tests/serviceworker/chromium/registration-stress.html [ Failure ]
 crbug.com/577380 [ Linux Debug ]
virtual/mojo-loading/http/tests/serviceworker/chromium/registration-stress.html
[ Failure ]
@@ -2251,8 +2253,8 @@
 crbug.com/664819
virtual/mojo-loading/http/tests/security/isolatedWorld/events.html [ Pass
Failure ]
 crbug.com/664839
virtual/mojo-loading/http/tests/security/link-crossorigin-preload-no-cors.html [
Pass Failure ]
 
-crbug.com/686478 fast/text/ellipsis-with-list-marker-in-ltr-flow.html [
NeedsRebaseline ]
-crbug.com/686478 fast/text/ellipsis-with-list-marker-in-rtl-flow.html [
NeedsRebaseline ]
+crbug.com/686478 fast/text/ellipsis-with-list-marker-in-ltr-flow.html [ Pass
Failure ]
+crbug.com/686478 fast/text/ellipsis-with-list-marker-in-rtl-flow.html [ Pass
Failure ]
 
 # Possible duplicate of crbug.com/498539
 # crbug.com/664843 inspector/elements/styles-4/styles-update-from-js.html [
Pass Failure ]

Powered by Google App Engine
This is Rietveld 408576698