Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1554)

Issue 2704023002: Unskip more tests that are no longer flaky (Closed)

Created:
3 years, 10 months ago by rhogan
Modified:
3 years, 10 months ago
Reviewers:
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unskip more tests that are no longer flaky Follow up to https://codereview.chromium.org/2686693002, these tests should no longer be flaky. TBR=eae@chromium.org BUG=663855 Review-Url: https://codereview.chromium.org/2704023002 Cr-Commit-Position: refs/heads/master@{#451486} Committed: https://chromium.googlesource.com/chromium/src/+/f0d8d6ac72c8c8e0bf7447abe2ba455caf12d8cf

Patch Set 1 #

Patch Set 2 : bug 663855-2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704023002/1
3 years, 10 months ago (2017-02-18 16:00:20 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/391332)
3 years, 10 months ago (2017-02-18 17:42:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704023002/20001
3 years, 10 months ago (2017-02-18 18:03:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f0d8d6ac72c8c8e0bf7447abe2ba455caf12d8cf
3 years, 10 months ago (2017-02-18 19:09:42 UTC) #10
rhogan
3 years, 10 months ago (2017-02-19 11:36:35 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2706693002/ by robhogan@gmail.com.

The reason for reverting is: text-overflow-ellipsis-button.html still fails on
Mac.

Powered by Google App Engine
This is Rietveld 408576698