Remove FrameView::m_doFullRepaint

Source/core/rendering/RenderBlock.cpp

Index: Source/core/rendering/RenderBlock.cpp
diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp
index 1b63df3ee3d758186366cc5d4738a3e749797f03..91d5d2580be07fc62bf12417cfc1c878ccb1a324 100644
--- a/Source/core/rendering/RenderBlock.cpp
+++ b/Source/core/rendering/RenderBlock.cpp
@@ -365,8 +365,6 @@ void RenderBlock::repaintTreeAfterLayout(const RenderLayerModelObject& repaintCo
     if (!shouldCheckForInvalidationAfterLayout())
         return;
 
-    RenderBox::repaintTreeAfterLayout(repaintContainer);
-
     // Take care of positioned objects. This is required as LayoutState keeps a single clip rect.
     if (TrackedRendererListHashSet* positionedObjects = this->positionedObjects()) {
         TrackedRendererListHashSet::iterator end = positionedObjects->end();
@@ -396,6 +394,8 @@ void RenderBlock::repaintTreeAfterLayout(const RenderLayerModelObject& repaintCo
             box->repaintTreeAfterLayout(repaintContainerForChild);
         }
     }
+
+    RenderBox::repaintTreeAfterLayout(repaintContainer);

[dsinclair, 2014/05/20 17:37:39]

This seems wrong to me. We should invalidate the parent before we invalidate the
children but this is flipping things around so the children are invalidated
first in this case.

[Xianzhu, 2014/05/20 18:32:21]

Made the change because I'm using the
RenderView::shouldDoFullRepaintAfterLayout() to indicate the RenderView's full
repaint requirement and need the flag to be cleared at last.

I was also afraid whether this would cause problems, but the layout test results
look OK to me. Could you give more details about the bad consequence of this
change?

[dsinclair, 2014/05/20 18:36:42]

I don't have any specific consequences, it just strikes me as being strange, and
also this is the only place where we have this behaviour. Seems like it will
bite us in the future if someone moves this to be above the child painting.

For all other places where we walk the tree we invalidate the parent and then
the children, except here.

 }
 
 RenderBlock* RenderBlock::continuationBefore(RenderObject* beforeChild)