Remove FrameView::m_doFullRepaint

Source/core/rendering/RenderBlock.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 347 matching lines @@
         ResourceLoadPriorityOptimizer::resourceLoadPriorityOptimizer()->removeRenderObject(this);
     else
         ResourceLoadPriorityOptimizer::resourceLoadPriorityOptimizer()->addRenderObject(this);
 }
 
 void RenderBlock::repaintTreeAfterLayout(const RenderLayerModelObject& repaintContainer)
 {
     if (!shouldCheckForInvalidationAfterLayout())
         return;
 
-    RenderBox::repaintTreeAfterLayout(repaintContainer);
-
     // Take care of positioned objects. This is required as LayoutState keeps a single clip rect.
     if (TrackedRendererListHashSet* positionedObjects = this->positionedObjects()) {
         TrackedRendererListHashSet::iterator end = positionedObjects->end();
         LayoutStateMaintainer statePusher(*this, isTableRow() ? LayoutSize() : locationOffset());
         for (TrackedRendererListHashSet::iterator it = positionedObjects->begin(); it != end; ++it) {
             RenderBox* box = *it;
 
             // One of the renderers we're skipping over here may be the child's repaint container,
             // so we can't pass our own repaint container along.
             const RenderLayerModelObject& repaintContainerForChild = *box->containerForRepaint();
 
             // If the positioned renderer is absolutely positioned and it is inside
             // a relatively positioend inline element, we need to account for
             // the inline elements position in LayoutState.
             if (box->style()->position() == AbsolutePosition) {
                 RenderObject* container = box->container(&repaintContainerForChild, 0);
                 if (container->isInFlowPositioned() && container->isRenderInline()) {
                     // FIXME: We should be able to use layout-state for this.
                     // Currently, we will place absolutly positioned elements inside
                     // relatively positioned inline blocks in the wrong location. crbug.com/371485
                     LayoutStateDisabler disable(*this);
                     box->repaintTreeAfterLayout(repaintContainerForChild);
                     continue;
                 }
             }
 
             box->repaintTreeAfterLayout(repaintContainerForChild);
         }
     }
+
+    RenderBox::repaintTreeAfterLayout(repaintContainer);

[dsinclair, 2014/05/20 17:37:39]

This seems wrong to me. We should invalidate the parent before we invalidate the
children but this is flipping things around so the children are invalidated
first in this case.

[Xianzhu, 2014/05/20 18:32:21]

Made the change because I'm using the
RenderView::shouldDoFullRepaintAfterLayout() to indicate the RenderView's full
repaint requirement and need the flag to be cleared at last.

I was also afraid whether this would cause problems, but the layout test results
look OK to me. Could you give more details about the bad consequence of this
change?

[dsinclair, 2014/05/20 18:36:42]

I don't have any specific consequences, it just strikes me as being strange, and
also this is the only place where we have this behaviour. Seems like it will
bite us in the future if someone moves this to be above the child painting.

For all other places where we walk the tree we invalidate the parent and then
the children, except here.

 }
 
 RenderBlock* RenderBlock::continuationBefore(RenderObject* beforeChild)
 {
     if (beforeChild && beforeChild->parent() == this)
         return this;
 
     RenderBlock* curr = toRenderBlock(continuation());
     RenderBlock* nextToLast = this;
     RenderBlock* last = this;
@@ skipping 4583 matching lines @@
 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* markedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const RenderObject* obj) const
 {
     showRenderObject();
     for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRootBox())
         root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLabel2, obj, 1);
 }
 
 #endif
 
 } // namespace WebCore