[Presentation API] Mojo typemap for content::PresentationConnectionMessage

chrome/browser/media/cast_remoting_connector_unittest.cc

Index: chrome/browser/media/cast_remoting_connector_unittest.cc
diff --git a/chrome/browser/media/cast_remoting_connector_unittest.cc b/chrome/browser/media/cast_remoting_connector_unittest.cc
index bf613be2dea95248d871206a558156745e146f31..17fceb5c768a1d2a50d557e13624b29a5707307a 100644
--- a/chrome/browser/media/cast_remoting_connector_unittest.cc
+++ b/chrome/browser/media/cast_remoting_connector_unittest.cc
@@ -165,26 +165,24 @@ class FakeMediaRouter : public media_router::MockMediaRouter {
   }
 
   void SendRouteMessage(const MediaRoute::Id& route_id,
-                        const std::string& text,
+                        std::string text,

[hubbe, 2017/03/01 01:05:56]

I don't get why we're doing this.
We're just moving where the copy happens to a less obvious place.

                         const SendRouteMessageCallback& callback) final {
     EXPECT_EQ(message_observer_->route_id(), route_id);
     ASSERT_FALSE(callback.is_null());
     RouteMessage message;
     message.type = RouteMessage::TEXT;
-    message.text = text;
+    message.text = std::move(text);
     outbound_messages_.push_back(std::make_pair(message, callback));
   }
 
-  void SendRouteBinaryMessage(
-      const MediaRoute::Id& route_id,
-      std::unique_ptr<std::vector<uint8_t>> data,
-      const SendRouteMessageCallback& callback) final {
+  void SendRouteBinaryMessage(const MediaRoute::Id& route_id,
+                              std::vector<uint8_t> data,

[hubbe, 2017/03/01 01:05:56]

This incurs a copy, why?

+                              const SendRouteMessageCallback& callback) final {
     EXPECT_EQ(message_observer_->route_id(), route_id);
-    ASSERT_TRUE(!!data);
     ASSERT_FALSE(callback.is_null());
     RouteMessage message;
     message.type = RouteMessage::BINARY;
-    message.binary = std::move(*data);
+    message.binary = std::move(data);
     outbound_messages_.push_back(std::make_pair(message, callback));
   }