[Presentation API] Mojo typemap for content::PresentationConnectionMessage

chrome/browser/media/cast_remoting_connector_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/cast_remoting_connector.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/callback.h"
@@ skipping 147 matching lines @@
     message_observer_ = observer;
     CHECK(message_observer_);
   }
 
   void UnregisterRouteMessageObserver(RouteMessageObserver* observer) final {
     CHECK_EQ(message_observer_, observer);
     message_observer_ = nullptr;
   }
 
   void SendRouteMessage(const MediaRoute::Id& route_id,
-                        const std::string& text,
+                        std::string text,

[hubbe, 2017/03/01 01:05:56]

I don't get why we're doing this.
We're just moving where the copy happens to a less obvious place.

                         const SendRouteMessageCallback& callback) final {
     EXPECT_EQ(message_observer_->route_id(), route_id);
     ASSERT_FALSE(callback.is_null());
     RouteMessage message;
     message.type = RouteMessage::TEXT;
-    message.text = text;
+    message.text = std::move(text);
     outbound_messages_.push_back(std::make_pair(message, callback));
   }
 
-  void SendRouteBinaryMessage(
-      const MediaRoute::Id& route_id,
-      std::unique_ptr<std::vector<uint8_t>> data,
-      const SendRouteMessageCallback& callback) final {
+  void SendRouteBinaryMessage(const MediaRoute::Id& route_id,
+                              std::vector<uint8_t> data,

[hubbe, 2017/03/01 01:05:56]

This incurs a copy, why?

+                              const SendRouteMessageCallback& callback) final {
     EXPECT_EQ(message_observer_->route_id(), route_id);
-    ASSERT_TRUE(!!data);
     ASSERT_FALSE(callback.is_null());
     RouteMessage message;
     message.type = RouteMessage::BINARY;
-    message.binary = std::move(*data);
+    message.binary = std::move(data);
     outbound_messages_.push_back(std::make_pair(message, callback));
   }
 
  private:
   // Asynchronous callback to notify the MediaRoutesObserver of a change in
   // routes.
   void DoUpdateRoutes() {
     if (routes_observer_)
       routes_observer_->OnRoutesUpdated(routes_, std::vector<MediaRoute::Id>());
   }
@@ skipping 412 matching lines @@
       break;
     }
   }
 }
 
 INSTANTIATE_TEST_CASE_P(, CastRemotingConnectorFullSessionTest,
                         ::testing::Values(SOURCE_TERMINATES,
                                           MOJO_PIPE_CLOSES,
                                           ROUTE_TERMINATES,
                                           EXTERNAL_FAILURE));