Remove non-MD code from StatusAreaWidgetDelegate

Remove non-MD code from StatusAreaWidgetDelegate

BUG=687811
TEST=none

Review-Url: https://codereview.chromium.org/2706403013
Cr-Commit-Position: refs/heads/master@{#453747}
Committed: https://chromium.googlesource.com/chromium/src/+/4a215673633de7ad54ddafefe318d5f1a24890f3

[mohsen, 2017-02-23 22:18:55]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 22:19:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2017-02-23 22:54:14]

mohsen@chromium.org changed reviewers:
+ tdanderson@chromium.org

[mohsen, 2017-02-23 22:54:14]

Please take a look...

[commit-bot: I haz the power, 2017-02-23 22:54:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 22:54:52]

Dry run: This issue passed the CQ dry run.

[tdanderson, 2017-02-28 16:37:08]

LGTM with one comment addressed, and my apologies for the delay in reviewing.

https://codereview.chromium.org/2706403013/diff/1/ash/common/system/status_ar...
File ash/common/system/status_area_widget_delegate.cc (right):

https://codereview.chromium.org/2706403013/diff/1/ash/common/system/status_ar...
ash/common/system/status_area_widget_delegate.cc:177: const int padding =
(GetShelfConstant(SHELF_SIZE) - kTrayItemSize) / 2;
Please replace SHELF_SIZE with just a single kShelfSize constant in
shelf_constants, since the non-MD value is no longer needed.

[tdanderson, 2017-02-28 16:40:00]

On 2017/02/28 16:37:08, tdanderson wrote:
> LGTM with one comment addressed, and my apologies for the delay in reviewing.
> 
>
https://codereview.chromium.org/2706403013/diff/1/ash/common/system/status_ar...
> File ash/common/system/status_area_widget_delegate.cc (right):
> 
>
https://codereview.chromium.org/2706403013/diff/1/ash/common/system/status_ar...
> ash/common/system/status_area_widget_delegate.cc:177: const int padding =
> (GetShelfConstant(SHELF_SIZE) - kTrayItemSize) / 2;
> Please replace SHELF_SIZE with just a single kShelfSize constant in
> shelf_constants, since the non-MD value is no longer needed.

Actually Evan has a CL that already does this (I'm reviewing it
right now) so just wait for his to land, rebase this, and then
LGTM to land. https://chromiumcodereview.appspot.com/2709903004/

[mohsen, 2017-02-28 16:45:41]

On 2017/02/28 at 16:40:00, tdanderson wrote:
> On 2017/02/28 16:37:08, tdanderson wrote:
> > LGTM with one comment addressed, and my apologies for the delay in
reviewing.
> > 
> >
https://codereview.chromium.org/2706403013/diff/1/ash/common/system/status_ar...
> > File ash/common/system/status_area_widget_delegate.cc (right):
> > 
> >
https://codereview.chromium.org/2706403013/diff/1/ash/common/system/status_ar...
> > ash/common/system/status_area_widget_delegate.cc:177: const int padding =
> > (GetShelfConstant(SHELF_SIZE) - kTrayItemSize) / 2;
> > Please replace SHELF_SIZE with just a single kShelfSize constant in
> > shelf_constants, since the non-MD value is no longer needed.
> 
> Actually Evan has a CL that already does this (I'm reviewing it
> right now) so just wait for his to land, rebase this, and then
> LGTM to land. https://chromiumcodereview.appspot.com/2709903004/

Since SHELF_SIZE is used in a few other places, I was planning to remove it
after non-MD is removed from those other places (for which I have CLs under
review or in CQ). Will rebase if Evan's CL landed first.

[mohsen, 2017-02-28 20:38:04]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 20:38:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2017-02-28 21:07:26]

mohsen@chromium.org changed reviewers:
+ jamescook@chromium.org

[mohsen, 2017-02-28 21:07:27]

jamescook@: Can you take a look at files in ash/common/shelf/?

[commit-bot: I haz the power, 2017-02-28 21:11:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 21:11:59]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-02-28 21:38:26]

LGTM

[mohsen, 2017-02-28 21:55:28]

The CQ bit was checked by mohsen@chromium.org

[mohsen, 2017-02-28 21:55:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2706403013/#ps20001
(title: "Rebased + Removed unused constant")

[commit-bot: I haz the power, 2017-02-28 21:56:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 22:04:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 22:04:52]

Failed to apply patch for ash/common/shelf/shelf_constants.cc:
While running git apply --index -p1;
  error: patch failed: ash/common/shelf/shelf_constants.cc:13
  error: ash/common/shelf/shelf_constants.cc: patch does not apply

Patch:       ash/common/shelf/shelf_constants.cc
Index: ash/common/shelf/shelf_constants.cc
diff --git a/ash/common/shelf/shelf_constants.cc
b/ash/common/shelf/shelf_constants.cc
index
53b90f41649522083e9250417f6399bbc2fae602..286765e0e1ae5dbbac5a2858fd81db79271b8d4f
100644
--- a/ash/common/shelf/shelf_constants.cc
+++ b/ash/common/shelf/shelf_constants.cc
@@ -13,7 +13,6 @@ const int kTimeToSwitchBackgroundMs = 1000;
 const int kWorkspaceAreaVisibleInset = 2;
 const int kWorkspaceAreaAutoHideInset = 5;
 const int kShelfAutoHideSize = 3;
-const int kShelfItemInset = 3;
 const SkColor kShelfDefaultBaseColor = SK_ColorBLACK;
 const SkColor kShelfButtonActivatedHighlightColor =
     SkColorSetA(SK_ColorWHITE, 100);

[mohsen, 2017-02-28 22:43:47]

The CQ bit was checked by mohsen@chromium.org

[mohsen, 2017-02-28 22:43:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2706403013/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2017-02-28 22:44:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 23:46:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488321827095770,
"parent_rev": "0c0f9ef081109ce6fdeee588d356238272d7b9f8", "commit_rev":
"4a215673633de7ad54ddafefe318d5f1a24890f3"}

[commit-bot: I haz the power, 2017-02-28 23:46:48]

Description was changed from

==========
Remove non-MD code from StatusAreaWidgetDelegate

BUG=687811
TEST=none
==========

to

==========
Remove non-MD code from StatusAreaWidgetDelegate

BUG=687811
TEST=none

Review-Url: https://codereview.chromium.org/2706403013
Cr-Commit-Position: refs/heads/master@{#453747}
Committed:
https://chromium.googlesource.com/chromium/src/+/4a215673633de7ad54ddafefe318...
==========

[commit-bot: I haz the power, 2017-02-28 23:46:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4a215673633de7ad54ddafefe318...