Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2706403013: Remove non-MD code from StatusAreaWidgetDelegate (Closed)

Created:
3 years, 10 months ago by mohsen
Modified:
3 years, 9 months ago
Reviewers:
tdanderson, James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-MD code from StatusAreaWidgetDelegate BUG=687811 TEST=none Review-Url: https://codereview.chromium.org/2706403013 Cr-Commit-Position: refs/heads/master@{#453747} Committed: https://chromium.googlesource.com/chromium/src/+/4a215673633de7ad54ddafefe318d5f1a24890f3

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased + Removed unused constant #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -65 lines) Patch
M ash/common/shelf/shelf_constants.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M ash/common/shelf/shelf_constants.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/status_area_widget_delegate.cc View 3 chunks +14 lines, -47 lines 0 comments Download
M ash/common/system/tray/tray_constants.h View 1 chunk +3 lines, -7 lines 0 comments Download
M ash/common/system/tray/tray_constants.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
mohsen
Please take a look...
3 years, 10 months ago (2017-02-23 22:54:14 UTC) #4
tdanderson
LGTM with one comment addressed, and my apologies for the delay in reviewing. https://codereview.chromium.org/2706403013/diff/1/ash/common/system/status_area_widget_delegate.cc File ...
3 years, 9 months ago (2017-02-28 16:37:08 UTC) #7
tdanderson
On 2017/02/28 16:37:08, tdanderson wrote: > LGTM with one comment addressed, and my apologies for ...
3 years, 9 months ago (2017-02-28 16:40:00 UTC) #8
mohsen
On 2017/02/28 at 16:40:00, tdanderson wrote: > On 2017/02/28 16:37:08, tdanderson wrote: > > LGTM ...
3 years, 9 months ago (2017-02-28 16:45:41 UTC) #9
mohsen
jamescook@: Can you take a look at files in ash/common/shelf/?
3 years, 9 months ago (2017-02-28 21:07:27 UTC) #13
James Cook
LGTM
3 years, 9 months ago (2017-02-28 21:38:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706403013/20001
3 years, 9 months ago (2017-02-28 21:56:18 UTC) #19
commit-bot: I haz the power
Failed to apply patch for ash/common/shelf/shelf_constants.cc: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-02-28 22:04:52 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706403013/40001
3 years, 9 months ago (2017-02-28 22:44:19 UTC) #24
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 23:46:49 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4a215673633de7ad54ddafefe318...

Powered by Google App Engine
This is Rietveld 408576698