Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2706403009: Revert of Updated tab history classes to use NavigationItemLists. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Updated tab history classes to use NavigationItemLists. (patchset #7 id:120001 of https://codereview.chromium.org/2693013005/ ) Reason for revert: Tests VisibleURLTestCase.testHistoryNavigation and FormsTestCase.testRepostFormAfterIndexNavigation are broken ( see https://bugs.chromium.org/p/chromium/issues/detail?id=695413 ). Original issue's description: > Updated tab history classes to use NavigationItemLists. > > This CL also updates these classes to use modern Objective-C syntax > and to follow the style guide (i.e. no property accessors in init). > > BUG=454984, 546355 > > Review-Url: https://codereview.chromium.org/2693013005 > Cr-Commit-Position: refs/heads/master@{#452241} > Committed: https://chromium.googlesource.com/chromium/src/+/0d966a54af810d7328692553e9bfc21bda33a990 TBR=eugenebut@chromium.org,kkhorimoto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454984, 546355 Review-Url: https://codereview.chromium.org/2706403009 Cr-Commit-Position: refs/heads/master@{#452478} Committed: https://chromium.googlesource.com/chromium/src/+/212e2cba544c82dac15fc1759f6b3bf688c6ee65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -280 lines) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/history/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
A ios/chrome/browser/ui/history/DEPS View 1 chunk +15 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/history/tab_history_cell.h View 1 chunk +5 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/history/tab_history_cell.mm View 7 chunks +51 lines, -24 lines 0 comments Download
M ios/chrome/browser/ui/history/tab_history_popup_controller.h View 1 chunk +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/history/tab_history_popup_controller.mm View 5 chunks +56 lines, -52 lines 0 comments Download
M ios/chrome/browser/ui/history/tab_history_popup_controller_egtest.mm View 3 chunks +4 lines, -12 lines 0 comments Download
M ios/chrome/browser/ui/history/tab_history_popup_controller_unittest.mm View 5 chunks +59 lines, -42 lines 0 comments Download
M ios/chrome/browser/ui/history/tab_history_view_controller.h View 1 chunk +4 lines, -13 lines 0 comments Download
M ios/chrome/browser/ui/history/tab_history_view_controller.mm View 7 chunks +115 lines, -112 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/web_toolbar_controller.h View 2 chunks +1 line, -2 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
lody
Created Revert of Updated tab history classes to use NavigationItemLists.
3 years, 10 months ago (2017-02-23 12:39:54 UTC) #1
sdefresne
lgtm
3 years, 10 months ago (2017-02-23 13:47:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706403009/1
3 years, 10 months ago (2017-02-23 13:49:28 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 13:50:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/212e2cba544c82dac15fc1759f6b...

Powered by Google App Engine
This is Rietveld 408576698