Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2706403004: mus: Makes ~WindowTreeClient reset context factory (Closed)

Created:
3 years, 10 months ago by sky
Modified:
3 years, 10 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Makes ~WindowTreeClient reset context factory If WindowTreeClient sets the context_factory, then in it's destructor it should reset the ContextFactory. BUG=none TEST=covered by tests R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2706403004 Cr-Commit-Position: refs/heads/master@{#452381} Committed: https://chromium.googlesource.com/chromium/src/+/55c8300d35c4c6abbb480e709f571b66658e80e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -26 lines) Patch
M ash/mus/window_manager_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 2 chunks +6 lines, -4 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
sky
3 years, 10 months ago (2017-02-22 17:53:19 UTC) #1
sadrul
lgtm
3 years, 10 months ago (2017-02-23 03:45:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706403004/1
3 years, 10 months ago (2017-02-23 03:48:46 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 03:54:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/55c8300d35c4c6abbb480e709f57...

Powered by Google App Engine
This is Rietveld 408576698