Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2706373002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, sadrul, dmazzoni+watch_chromium.org, agrieve+watch_chromium.org, extensions-reviews_chromium.org, aboxhall, aboxhall+watch_chromium.org, jam, abarth-chromium, je_julie, darin-cc_chromium.org, blink-reviews, kalyank, mlamouri+watch-content_chromium.org, alemate+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, haraken, tfarina, nektar+watch_chromium.org, nektarios, dtseng+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2706373002 Cr-Commit-Position: refs/heads/master@{#452631} Committed: https://chromium.googlesource.com/chromium/src/+/3ba53ca6204ec673ee9c1464ad1e3cb12352af4c

Patch Set 1 #

Patch Set 2 : update component #

Total comments: 22

Patch Set 3 : update team/component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
M chrome/browser/accessibility/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/braille_display_private/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/system_private/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/braille_ime/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/select_to_speak/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/speech/extension_api/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/accessibility/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/aura/accessibility/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/accessibility/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/third_party/chromevox/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/resources/accessibility/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/accessibility/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/data/accessibility/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/iaccessible2/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/isimpledom/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/liblouis/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/speech-dispatcher/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tools/accessibility/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tools/accessibility/nvda/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/accessibility/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/accessibility/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-21 23:18:13 UTC) #3
dmazzoni
lgtm with all of the changes below You can use TEAM: chromium-accessibility@chromium.org for all of ...
3 years, 10 months ago (2017-02-22 05:29:20 UTC) #4
ymzhang1
Thanks for the comments and providing team mailing list! https://codereview.chromium.org/2706373002/diff/20001/chrome/browser/extensions/api/braille_display_private/OWNERS File chrome/browser/extensions/api/braille_display_private/OWNERS (right): https://codereview.chromium.org/2706373002/diff/20001/chrome/browser/extensions/api/braille_display_private/OWNERS#newcode5 chrome/browser/extensions/api/braille_display_private/OWNERS:5: ...
3 years, 10 months ago (2017-02-23 19:09:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706373002/60001
3 years, 10 months ago (2017-02-23 19:16:40 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 21:15:35 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3ba53ca6204ec673ee9c1464ad1e...

Powered by Google App Engine
This is Rietveld 408576698