Implement handleQualified with 1 dot.

Implement handleQualified with 1 dot.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/fdb370ca833ca727f037797ae4581a7fe8f3bf46

[Paul Berry, 2017-02-21 22:22:36]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[scheglov, 2017-02-21 22:26:52]

LGTM

[Paul Berry, 2017-02-21 23:02:31]

Description was changed from

==========
Implement handleQualified with 1 dot.
==========

to

==========
Implement handleQualified with 1 dot.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fdb370ca833ca727f037797ae4581a7fe8f3bf46
==========

[Paul Berry, 2017-02-21 23:02:33]

Committed patchset #1 (id:1) manually as
fdb370ca833ca727f037797ae4581a7fe8f3bf46 (presubmit successful).

[ahe, 2017-02-22 11:42:08]

lgtm

One minor action item below: a long line.

https://codereview.chromium.org/2706343002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2706343002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:462: // element?
We should try to share this method with BodyBuilder.

Here's how I handle errors there:

        push(const DynamicType());
        addCompileTimeError(beginToken.charOffset,
            "Can't be used as a type: '${debugName(prefix, suffix)}'.");
        return;

But it seems you can do slightly better by installing dynamic on the type name.

https://codereview.chromium.org/2706343002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:466: // set the static
element at the time that handleIdentifier was called.
For inspiration (or code sharing) take a look at
BodyBuilder.builderToFirstExpression.

https://codereview.chromium.org/2706343002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:954: // TODO(paulberry):
resolve [identifier].
I'm using SendAccessor to handle this in BodyBuilder.

https://codereview.chromium.org/2706343002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:955:
push(ast.prefixedIdentifier(prefix, toAnalyzerToken(period), identifier));
Long line.

[Paul Berry, 2017-02-22 16:34:54]

https://codereview.chromium.org/2706343002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2706343002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:462: // element?
On 2017/02/22 11:42:08, ahe wrote:
> We should try to share this method with BodyBuilder.
> 
> Here's how I handle errors there:
> 
>         push(const DynamicType());
>         addCompileTimeError(beginToken.charOffset,
>             "Can't be used as a type: '${debugName(prefix, suffix)}'.");
>         return;
> 
> But it seems you can do slightly better by installing dynamic on the type
name.

Acknowledged.

https://codereview.chromium.org/2706343002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:466: // set the static
element at the time that handleIdentifier was called.
On 2017/02/22 11:42:08, ahe wrote:
> For inspiration (or code sharing) take a look at
> BodyBuilder.builderToFirstExpression.

Acknowledged.

https://codereview.chromium.org/2706343002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:954: // TODO(paulberry):
resolve [identifier].
On 2017/02/22 11:42:08, ahe wrote:
> I'm using SendAccessor to handle this in BodyBuilder.

Acknowledged.

https://codereview.chromium.org/2706343002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:955:
push(ast.prefixedIdentifier(prefix, toAnalyzerToken(period), identifier));
On 2017/02/22 11:42:08, ahe wrote:
> Long line.

Thanks.  Konstantin fixed this in https://codereview.chromium.org/2705333002.