Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2705333002: Pass 'classKeyword' to endClassDeclaratio() and endNamedMixinApplication(). (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pass 'classKeyword' to endClassDeclaratio() and endNamedMixinApplication(). R=ahe@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9a3f8224a475b98b45de80529ae9f80a1f45dd44

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -44 lines) Patch
M pkg/compiler/lib/src/parser/element_listener.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 4 chunks +4 lines, -18 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 3 chunks +12 lines, -7 lines 2 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 10 months ago (2017-02-21 22:50:04 UTC) #1
Paul Berry
front_end changes lgtm. I don't feel qualified to review the dart2js changes.
3 years, 10 months ago (2017-02-21 23:01:40 UTC) #2
ahe
lgtm Please make sure to run dart2js tests before submitting. https://codereview.chromium.org/2705333002/diff/1/pkg/front_end/lib/src/fasta/parser/parser.dart File pkg/front_end/lib/src/fasta/parser/parser.dart (right): https://codereview.chromium.org/2705333002/diff/1/pkg/front_end/lib/src/fasta/parser/parser.dart#newcode716 ...
3 years, 10 months ago (2017-02-22 05:48:27 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as 9a3f8224a475b98b45de80529ae9f80a1f45dd44 (presubmit successful).
3 years, 10 months ago (2017-02-22 06:13:12 UTC) #5
scheglov
3 years, 10 months ago (2017-02-22 06:13:27 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2705333002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2705333002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:716: }
On 2017/02/22 05:48:27, ahe wrote:
> How about adding
> 
> assert(optional("class", classKeyword));
> 
> here?

Done.

Powered by Google App Engine
This is Rietveld 408576698