Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2706333004: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 Review-Url: https://codereview.chromium.org/2706333004 Cr-Commit-Position: refs/heads/master@{#453261} Committed: https://chromium.googlesource.com/chromium/src/+/f18bc0445922b559aef7d0d0f3f83f0375fd94e8

Patch Set 1 #

Total comments: 1

Patch Set 2 : update component/team #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ash/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/ash/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/shell/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-22 19:04:22 UTC) #2
James Cook
LGTM with one change request https://codereview.chromium.org/2706333004/diff/1/extensions/shell/OWNERS File extensions/shell/OWNERS (right): https://codereview.chromium.org/2706333004/diff/1/extensions/shell/OWNERS#newcode5 extensions/shell/OWNERS:5: # COMPONENT: UI>Shell I ...
3 years, 9 months ago (2017-02-27 15:02:51 UTC) #3
ymzhang1
Thanks for the comments.
3 years, 9 months ago (2017-02-27 17:57:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706333004/20001
3 years, 9 months ago (2017-02-27 18:02:16 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 18:15:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f18bc0445922b559aef7d0d0f3f8...

Powered by Google App Engine
This is Rietveld 408576698