[TTS] Add a Java Context linked to existing native

[TTS] Add a Java Context linked to existing native
    
Refactor Contextual Search to use a Java Context linked to the
native Context we've had for a while.
    
Update the native context have only private data members.
    
Also fix some minor bugs regarding the panel not updating when
a retap is done, and expanding the selection when it's been
changed.
    
Additional refactoring includes changing the API to the native
Contextual Search Manager to have StartSearchTermResolutionRequest
not automatically gather surrounding text -- that call must now be
done separately.
    
Also use WebContents instead of ContentViewCore, and some other
cleanup.
    
BUG=692824, 699305, 693297
Review-Url: https://codereview.chromium.org/2706333002
Cr-Commit-Position: refs/heads/master@{#456087}
Committed: https://chromium.googlesource.com/chromium/src/+/4740983c521d7ac5ace825964eabddadf64507b8

[Donn Denman, 2017-03-07 20:31:32]

The CQ bit was checked by donnd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 20:33:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 22:11:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 22:11:39]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Donn Denman, 2017-03-08 00:50:05]

donnd@chromium.org changed reviewers:
+ twellington@chromium.org

[Donn Denman, 2017-03-08 00:50:05]

Theresa, this is ready for a quick first-look.  Thanks!

[Donn Denman, 2017-03-08 00:50:26]

The CQ bit was checked by donnd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 00:51:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 01:35:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 01:35:40]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Theresa, 2017-03-08 01:54:38]

I like the overall approach. It's great to see the context and a full-fledged
Object.

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java
(right):

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java:16:
private final String mSelection;
nit: final variables go first.

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java:37:
ContextualSearchContext(String selection, String homeCountry, boolean
maySendBasePageUrl) {
nit: JavaDocs for parameters

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java:64:
private void clearNativePointer() {
When is this called vs destroy()?

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
(right):

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java:436:
mContext = new ContextualSearchContext(
showContextualSearch() can be called due to a selection modification. I believe
that it may even be called twice with isTap if a selection is being modified due
to a second tap, but I'm not entirely sure.

Should we be destroying the old context?

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java:624:
mSearchPanel.setSearchContext(selection, afterText);
CSPanel#setSearchContext() probably needs to be renamed since it collides with
the new Java ContextualSearchContext class.

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java:755:
if (mSelectionController.getSelectedText() == mContext.getSelection()) {
I'm not quite sure what's happening here -- when would this be false?

Also, findbugs is complaining about the == comparison for Strings.

https://codereview.chromium.org/2706333002/diff/60001/chrome/browser/android/...
File chrome/browser/android/contextualsearch/contextual_search_context.h
(right):

https://codereview.chromium.org/2706333002/diff/60001/chrome/browser/android/...
chrome/browser/android/contextualsearch/contextual_search_context.h:40: void
SetUseBriefPageContent(JNIEnv* env,
Can this be combined with setProperties?

https://codereview.chromium.org/2706333002/diff/60001/chrome/browser/android/...
File chrome/browser/android/contextualsearch/contextual_search_delegate.cc
(right):

https://codereview.chromium.org/2706333002/diff/60001/chrome/browser/android/...
chrome/browser/android/contextualsearch/contextual_search_delegate.cc:121: void
ContextualSearchDelegate::StartSearchTermResolutionRequest(
nit: It looks like this method and the one above got swapped from their order in
the header file.

https://codereview.chromium.org/2706333002/diff/60001/chrome/browser/android/...
File chrome/browser/android/contextualsearch/contextual_search_delegate.h
(left):

https://codereview.chromium.org/2706333002/diff/60001/chrome/browser/android/...
chrome/browser/android/contextualsearch/contextual_search_delegate.h:246:
std::unique_ptr<ContextualSearchContext> context_;
Just to check my understanding - the ContextualSearchContext object
creation/destruction is owned in Java, so this no longer needs to be a 
std::unique_ptr?

[Donn Denman, 2017-03-09 04:43:03]

The CQ bit was checked by donnd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 04:43:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 06:14:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 06:14:36]

Dry run: This issue passed the CQ dry run.

[Donn Denman, 2017-03-09 17:35:05]

Theresa, this is ready for another quick look.

I don't like the way the native Context has public data members that are just
set and read willy-nilly.  I plan to work on making accessors, so feel free to
hold off looking until then, or just doing a super-fast pass (e.g. just reading
my responses to your comments, responding to them.).

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java
(right):

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java:16:
private final String mSelection;
On 2017/03/08 01:54:38, Theresa wrote:
> nit: final variables go first.

Done.

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java:37:
ContextualSearchContext(String selection, String homeCountry, boolean
maySendBasePageUrl) {
On 2017/03/08 01:54:38, Theresa wrote:
> nit: JavaDocs for parameters

Done.

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java:64:
private void clearNativePointer() {
On 2017/03/08 01:54:38, Theresa wrote:
> When is this called vs destroy()?

Added JavaDoc.

Destroy is called from the java, but clearNativePointer is called by the native
destructor so this class will let go of the pointer to the native instance.

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
(right):

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java:436:
mContext = new ContextualSearchContext(
On 2017/03/08 01:54:38, Theresa wrote:
> showContextualSearch() can be called due to a selection modification. I
believe
> that it may even be called twice with isTap if a selection is being modified
due
> to a second tap, but I'm not entirely sure.
> 
> Should we be destroying the old context?

We should have already destroyed any old context and set it to null.  Added an
assert here to verify that's been done.

Also updated the Icing case when constructing below (line 467).

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java:624:
mSearchPanel.setSearchContext(selection, afterText);
On 2017/03/08 01:54:38, Theresa wrote:
> CSPanel#setSearchContext() probably needs to be renamed since it collides with
> the new Java ContextualSearchContext class.

Done.

Changed to setContextDetails and cascaded that name change through to the
Context Control.

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java:755:
if (mSelectionController.getSelectedText() == mContext.getSelection()) {
On 2017/03/08 01:54:38, Theresa wrote:
> I'm not quite sure what's happening here -- when would this be false?
> 
> Also, findbugs is complaining about the == comparison for Strings.

This can happen when the user changes the selection while the resolve is in
progress.  When the selection has changed we shouldn't apply the adjustment, we
should just abort the search.

https://codereview.chromium.org/2706333002/diff/60001/chrome/browser/android/...
File chrome/browser/android/contextualsearch/contextual_search_context.h
(right):

https://codereview.chromium.org/2706333002/diff/60001/chrome/browser/android/...
chrome/browser/android/contextualsearch/contextual_search_context.h:40: void
SetUseBriefPageContent(JNIEnv* env,
On 2017/03/08 01:54:38, Theresa wrote:
> Can this be combined with setProperties?

Done.

Changed the model from brief/normal context to a resolvable/not-resolvable
context, which caused a few name changes for clarity.

https://codereview.chromium.org/2706333002/diff/60001/chrome/browser/android/...
File chrome/browser/android/contextualsearch/contextual_search_delegate.cc
(right):

https://codereview.chromium.org/2706333002/diff/60001/chrome/browser/android/...
chrome/browser/android/contextualsearch/contextual_search_delegate.cc:121: void
ContextualSearchDelegate::StartSearchTermResolutionRequest(
On 2017/03/08 01:54:38, Theresa wrote:
> nit: It looks like this method and the one above got swapped from their order
in
> the header file.

Fixed -- Changed the order in the header file to be (Gather, Search).

https://codereview.chromium.org/2706333002/diff/60001/chrome/browser/android/...
File chrome/browser/android/contextualsearch/contextual_search_delegate.h
(left):

https://codereview.chromium.org/2706333002/diff/60001/chrome/browser/android/...
chrome/browser/android/contextualsearch/contextual_search_delegate.h:246:
std::unique_ptr<ContextualSearchContext> context_;
On 2017/03/08 01:54:38, Theresa wrote:
> Just to check my understanding - the ContextualSearchContext object
> creation/destruction is owned in Java, so this no longer needs to be a 
> std::unique_ptr?

That's right, it's now owned by the Java object.

[Theresa, 2017-03-09 18:29:44]

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java
(right):

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java:64:
private void clearNativePointer() {
On 2017/03/09 17:35:04, Donn Denman wrote:
> On 2017/03/08 01:54:38, Theresa wrote:
> > When is this called vs destroy()?
> 
> Added JavaDoc.
> 
> Destroy is called from the java, but clearNativePointer is called by the
native
> destructor so this class will let go of the pointer to the native instance.

What I was trying to ask is when is the object destroyed by Java and when is it
destroyed by native? Typically we only have one or the other and both methods
release the pointer to the native instance.

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
(right):

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java:755:
if (mSelectionController.getSelectedText() == mContext.getSelection()) {
On 2017/03/09 17:35:04, Donn Denman wrote:
> On 2017/03/08 01:54:38, Theresa wrote:
> > I'm not quite sure what's happening here -- when would this be false?
> > 
> > Also, findbugs is complaining about the == comparison for Strings.
> 
> This can happen when the user changes the selection while the resolve is in
> progress.  When the selection has changed we shouldn't apply the adjustment,
we
> should just abort the search.


That makes sense. In this scenario, should be do nothing here rather than
calling hideContextualSearch() (unless the selection is null)? We should be
doing a verbatim search for the new selection, but hopefully that's already
happened before this method is called.

[Donn Denman, 2017-03-09 21:57:42]

Description was changed from

==========
[TTS] Add a Java Context linked to existing native

BUG=692824
==========

to

==========
[TTS] Add a Java Context linked to existing native
    
Refactor Contextual Search to use a Java Context linked to the
native Context we've had for a while.
    
Update the native context have only private data members.
    
Also fix some minor bugs regarding the panel not updating when
a retap is done, and expanding the selection when it's been
changed.
    
Additional refactoring includes changing the API to the native
Contextual Search Manager to have StartSearchTermResolutionRequest
not automatically gather surrounding text -- that call must now be
done separately.
    
Also use WebContents instead of ContentViewCore, and some other
cleanup.
    
BUG=692824,699305,693297
==========

[Donn Denman, 2017-03-09 22:00:25]

Theresa, PTAL.

Thanks!

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java
(right):

https://codereview.chromium.org/2706333002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java:64:
private void clearNativePointer() {
On 2017/03/09 18:29:44, Theresa wrote:
> On 2017/03/09 17:35:04, Donn Denman wrote:
> > On 2017/03/08 01:54:38, Theresa wrote:
> > > When is this called vs destroy()?
> > 
> > Added JavaDoc.
> > 
> > Destroy is called from the java, but clearNativePointer is called by the
> native
> > destructor so this class will let go of the pointer to the native instance.
> 
> What I was trying to ask is when is the object destroyed by Java and when is
it
> destroyed by native? Typically we only have one or the other and both methods
> release the pointer to the native instance.
BTW, here's that sample code I was telling you about:
Documentation and quick reference are found in sample_for_tests.h &
SampleForTests.java.

I see.  Since we want to destroy in Java I can get rid of this
clearNativePointer and just have destroy clear it.  Thanks!

[Theresa, 2017-03-09 22:46:37]

lgtm % some nits -- thank you for taking this on! I think it's a significant
improvement.

https://codereview.chromium.org/2706333002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchContextControl.java
(right):

https://codereview.chromium.org/2706333002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchContextControl.java:46:
* Sets the search context to display in the control.
nit: this should be updated too?

https://codereview.chromium.org/2706333002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java
(right):

https://codereview.chromium.org/2706333002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java:54:
String getSelection() {
nit: JavaDoc for this -- "@return The initial selection..."

https://codereview.chromium.org/2706333002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java
(right):

https://codereview.chromium.org/2706333002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java:359:
* @param x The x coordinate.
nit: The x coordinate in px?

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
File chrome/browser/android/contextualsearch/contextual_search_context.h
(right):

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
chrome/browser/android/contextualsearch/contextual_search_context.h:30: //
Returns the native |ContextualSearchContext| given the java object.
nit: s/java/Java

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
chrome/browser/android/contextualsearch/contextual_search_context.h:55: // Gets
the encoding of the base page.  This is not very important, since
If it's not important, can we remove it?

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
chrome/browser/android/contextualsearch/contextual_search_context.h:77: // Gets
the end offset of the selection within the surrounding text.
Is this in characters or bytes?

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
File chrome/browser/android/contextualsearch/contextual_search_delegate.cc
(right):

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
chrome/browser/android/contextualsearch/contextual_search_delegate.cc:111: ?
field_trial_->GetSurroundingSize()
Not in this CL, but in a follow up one, it seems that we should have a
hard-coded surrounding size rather than getting it from the field_trial.

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
File chrome/browser/android/contextualsearch/contextual_search_delegate.h
(right):

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
chrome/browser/android/contextualsearch/contextual_search_delegate.h:79: // Only
needed for tests.  TODO(donnd): make private and friend?
If it's not too difficult, let's do this TODO now.

[Donn Denman, 2017-03-10 01:29:43]

Thanks Theresa!

https://codereview.chromium.org/2706333002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchContextControl.java
(right):

https://codereview.chromium.org/2706333002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchContextControl.java:46:
* Sets the search context to display in the control.
On 2017/03/09 22:46:37, Theresa wrote:
> nit: this should be updated too?

Done.

https://codereview.chromium.org/2706333002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java
(right):

https://codereview.chromium.org/2706333002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java:25:
ContextualSearchContext(String selection) {
Decided to remove the selection parameter, since it's not needed in this case. 
Now set to null.

https://codereview.chromium.org/2706333002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java:54:
String getSelection() {
On 2017/03/09 22:46:37, Theresa wrote:
> nit: JavaDoc for this -- "@return The initial selection..."

Done.

https://codereview.chromium.org/2706333002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java
(right):

https://codereview.chromium.org/2706333002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java:359:
* @param x The x coordinate.
On 2017/03/09 22:46:37, Theresa wrote:
> nit: The x coordinate in px?

Done.

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
File chrome/browser/android/contextualsearch/contextual_search_context.h
(right):

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
chrome/browser/android/contextualsearch/contextual_search_context.h:30: //
Returns the native |ContextualSearchContext| given the java object.
On 2017/03/09 22:46:37, Theresa wrote:
> nit: s/java/Java

Done.

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
chrome/browser/android/contextualsearch/contextual_search_context.h:55: // Gets
the encoding of the base page.  This is not very important, since
On 2017/03/09 22:46:37, Theresa wrote:
> If it's not important, can we remove it?

Unfortunately no, not easily.  We currently pass this through the listeners in
our Icing integration:
https://cs.chromium.org/search/?q=GSAContextDisplaySelection+encoding+notifyS...

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
chrome/browser/android/contextualsearch/contextual_search_context.h:77: // Gets
the end offset of the selection within the surrounding text.
On 2017/03/09 22:46:37, Theresa wrote:
> Is this in characters or bytes?

Done.

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
File chrome/browser/android/contextualsearch/contextual_search_delegate.cc
(right):

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
chrome/browser/android/contextualsearch/contextual_search_delegate.cc:111: ?
field_trial_->GetSurroundingSize()
On 2017/03/09 22:46:37, Theresa wrote:
> Not in this CL, but in a follow up one, it seems that we should have a
> hard-coded surrounding size rather than getting it from the field_trial.

Acknowledged.

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
File chrome/browser/android/contextualsearch/contextual_search_delegate.h
(right):

https://codereview.chromium.org/2706333002/diff/120001/chrome/browser/android...
chrome/browser/android/contextualsearch/contextual_search_delegate.h:79: // Only
needed for tests.  TODO(donnd): make private and friend?
On 2017/03/09 22:46:37, Theresa wrote:
> If it's not too difficult, let's do this TODO now.

Done.

[Donn Denman, 2017-03-10 01:29:51]

The CQ bit was checked by donnd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 01:30:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 02:52:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 02:52:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Donn Denman, 2017-03-10 03:51:44]

donnd@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Donn Denman, 2017-03-10 03:51:45]

Ted, PTAL at least for chrome_jni_registrar.cc

Thanks!

[Donn Denman, 2017-03-10 03:51:59]

The CQ bit was checked by donnd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 03:52:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ted C, 2017-03-10 04:34:01]

On 2017/03/10 03:51:45, Donn Denman wrote:
> Ted, PTAL at least for chrome_jni_registrar.cc
> 
> Thanks!

chrome_jni_registrar.cc - lgtm

[commit-bot: I haz the power, 2017-03-10 04:59:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 04:59:05]

Dry run: This issue passed the CQ dry run.

[Donn Denman, 2017-03-10 17:20:03]

The CQ bit was checked by donnd@chromium.org

[Donn Denman, 2017-03-10 17:20:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2706333002/#ps160001
(title: "Nothing, I think.")

[commit-bot: I haz the power, 2017-03-10 17:20:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 17:25:02]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1489166403203000,
"parent_rev": "a0edc14c6fae6412feb1fabdef2d7e3372cd86dd", "commit_rev":
"4740983c521d7ac5ace825964eabddadf64507b8"}

[commit-bot: I haz the power, 2017-03-10 17:25:45]

Description was changed from

==========
[TTS] Add a Java Context linked to existing native
    
Refactor Contextual Search to use a Java Context linked to the
native Context we've had for a while.
    
Update the native context have only private data members.
    
Also fix some minor bugs regarding the panel not updating when
a retap is done, and expanding the selection when it's been
changed.
    
Additional refactoring includes changing the API to the native
Contextual Search Manager to have StartSearchTermResolutionRequest
not automatically gather surrounding text -- that call must now be
done separately.
    
Also use WebContents instead of ContentViewCore, and some other
cleanup.
    
BUG=692824,699305,693297
==========

to

==========
[TTS] Add a Java Context linked to existing native
    
Refactor Contextual Search to use a Java Context linked to the
native Context we've had for a while.
    
Update the native context have only private data members.
    
Also fix some minor bugs regarding the panel not updating when
a retap is done, and expanding the selection when it's been
changed.
    
Additional refactoring includes changing the API to the native
Contextual Search Manager to have StartSearchTermResolutionRequest
not automatically gather surrounding text -- that call must now be
done separately.
    
Also use WebContents instead of ContentViewCore, and some other
cleanup.
    
BUG=692824,699305,693297

Review-Url: https://codereview.chromium.org/2706333002
Cr-Commit-Position: refs/heads/master@{#456087}
Committed:
https://chromium.googlesource.com/chromium/src/+/4740983c521d7ac5ace825964eab...
==========

[commit-bot: I haz the power, 2017-03-10 17:25:47]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/4740983c521d7ac5ace825964eab...