[IndexedDB] Added Observer UseCounter

[IndexedDB] Added Observer UseCounter

BUG=609934
Review-Url: https://codereview.chromium.org/2706293015
Cr-Commit-Position: refs/heads/master@{#460695}
Committed: https://chromium.googlesource.com/chromium/src/+/17d5123cacf79a64c47c6b040c1d6d4099fd8b77

[dmurph, 2017-02-24 23:57:23]

dmurph@chromium.org changed reviewers:
+ cmumford@chromium.org, jsbell@chromium.org

[dmurph, 2017-02-24 23:57:24]

Jsbell & cmumford, can you PTAL? This is adding UseCounters to the the observe
and unobserve calls.

[cmumford, 2017-03-07 21:51:54]

lgtm

[jsbell, 2017-03-07 22:40:33]

https://codereview.chromium.org/2706293015/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/2706293015/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/UseCounter.h:1479: IDBObserver_Observe =
1830,
We don't generally use _ in the enum members.

(The main exception is when you just use 'Measure' in the IDL and it generates
e.g. V8CSSRuleList_Item_Method. We do have a few others... most of which are my
fault. Oops.)

Maybe just use [Measure] and use the autogenerated name?
(V8IDBObserver_Observe_Method)

[dmurph, 2017-03-29 21:56:36]

The CQ bit was checked by dmurph@chromium.org to run a CQ dry run

[dmurph, 2017-03-29 21:57:00]

dmurph@chromium.org changed reviewers:
+ mpearson@chromium.org

[dmurph, 2017-03-29 21:57:01]

+mpearson for histograms.xml change.

[commit-bot: I haz the power, 2017-03-29 21:57:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark P, 2017-03-29 22:40:15]

histograms.xml lgtm

[dmurph, 2017-03-29 22:46:11]

The CQ bit was unchecked by dmurph@chromium.org

[dmurph, 2017-03-29 22:46:15]

The CQ bit was checked by dmurph@chromium.org

[dmurph, 2017-03-29 22:46:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
cmumford@chromium.org
Link to the patchset: https://codereview.chromium.org/2706293015/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2017-03-29 22:47:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 22:57:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 22:57:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dmurph, 2017-03-29 22:58:19]

dmurph@chromium.org changed reviewers:
+ mkwst@chromium.org

[dmurph, 2017-03-29 22:58:19]

whoops, need Josh and then UseCounter reviewer.
mkwst: can you PTAL at UseCounter.h?

https://codereview.chromium.org/2706293015/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/2706293015/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/UseCounter.h:1479: IDBObserver_Observe =
1830,
On 2017/03/07 22:40:33, jsbell wrote:
> We don't generally use _ in the enum members.
> 
> (The main exception is when you just use 'Measure' in the IDL and it generates
> e.g. V8CSSRuleList_Item_Method. We do have a few others... most of which are
my
> fault. Oops.)
> 
> Maybe just use [Measure] and use the autogenerated name?
> (V8IDBObserver_Observe_Method)

Done.

[haraken, 2017-03-30 00:05:54]

On 2017/03/29 22:58:19, dmurph wrote:
> whoops, need Josh and then UseCounter reviewer.
> mkwst: can you PTAL at UseCounter.h?

LGTM

[Mike West, 2017-03-30 06:31:56]

mkwst@chromium.org changed reviewers:
+ haraken@chromium.org

[Mike West, 2017-03-30 06:31:56]

LGTM 2, FWIW. :)

[dmurph, 2017-03-30 08:20:26]

The CQ bit was checked by dmurph@chromium.org

[commit-bot: I haz the power, 2017-03-30 08:20:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 08:28:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490862026135780,
"parent_rev": "8abc307dc86ed5ea727336a5a499aa9ea016e622", "commit_rev":
"17d5123cacf79a64c47c6b040c1d6d4099fd8b77"}

[commit-bot: I haz the power, 2017-03-30 08:29:36]

Description was changed from

==========
[IndexedDB] Added Observer UseCounter

BUG=609934
==========

to

==========
[IndexedDB] Added Observer UseCounter

BUG=609934

Review-Url: https://codereview.chromium.org/2706293015
Cr-Commit-Position: refs/heads/master@{#460695}
Committed:
https://chromium.googlesource.com/chromium/src/+/17d5123cacf79a64c47c6b040c1d...
==========

[commit-bot: I haz the power, 2017-03-30 08:29:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/17d5123cacf79a64c47c6b040c1d...