third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js - Issue 2706293007: [DevTools] Fix Dialog's close button to properly close dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js

Issue 2706293007: [DevTools] Fix Dialog's close button to properly close dialog. (Closed)

Patch Set: test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/Dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js b/third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js

index 47ef0408127099ec0e59b353e2dfdc1f1d4aae72..f2dbee6b981318ae2bd77d8538a685c6dc497349 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js

@@ -34,13 +34,13 @@ Sources.AddSourceMapURLDialog = class extends UI.HBox {

var addSourceMapURLDialog = new Sources.AddSourceMapURLDialog(done);

addSourceMapURLDialog.show(dialog.contentElement);

dialog.setSizeBehavior(UI.GlassPane.SizeBehavior.MeasureContent);

- dialog.showDialog();

+ dialog.show();

/**

* @param {string} value

function done(value) {

- dialog.hideDialog();

+ dialog.hide();

callback(value);

}