third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js - Issue 2706293007: [DevTools] Fix Dialog's close button to properly close dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

Issue 2706293007: [DevTools] Fix Dialog's close button to properly close dialog. (Closed)

Patch Set: test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

diff --git a/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js b/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

index 8ced0ffc09549a408fdfd1269c2e1d333034c2f6..c93437996713faed579ef8e0bd02b17b2d072203 100644

--- a/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

+++ b/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

@@ -72,7 +72,7 @@ Settings.SettingsScreen = class extends UI.VBox {

var dialog = new UI.Dialog();

dialog.addCloseButton();

settingsScreen.show(dialog.contentElement);

- dialog.showDialog();

+ dialog.show();

settingsScreen._selectTab(name || 'preferences');

}