Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2706243012: Fold svgAttributeChanged into parseAttribute for SVGAnimateElement (Closed)

Created:
3 years, 10 months ago by fs
Modified:
3 years, 10 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fold svgAttributeChanged into parseAttribute for SVGAnimateElement This separation does not really give much in terms of benefits. Since none of the SMIL-related attributes are exposed through SVG DOM, the former method is always called after the latter. Move the code from the former to the latter. This even avoids the attribute value lookup, for a tiny perf gain... BUG=641437 Review-Url: https://codereview.chromium.org/2706243012 Cr-Commit-Position: refs/heads/master@{#452861} Committed: https://chromium.googlesource.com/chromium/src/+/d7d7475a474a473efc0b9578305e663653df052f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 1 chunk +5 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 10 months ago (2017-02-24 14:22:08 UTC) #4
Stephen Chennney
On 2017/02/24 14:22:08, fs wrote: lgtm
3 years, 10 months ago (2017-02-24 16:14:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706243012/1
3 years, 10 months ago (2017-02-24 17:25:11 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 17:36:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d7d7475a474a473efc0b9578305e...

Powered by Google App Engine
This is Rietveld 408576698