Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2706243007: Don't assume that the permission manager exists. (Closed)

Created:
3 years, 10 months ago by Peter Beverloo
Modified:
3 years, 10 months ago
Reviewers:
Sami
CC:
chromium-reviews, Peter Beverloo, jam, johnme+watch_chromium.org, darin-cc_chromium.org, harkness+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't assume that the permission manager exists. It's valid for a browser context's permission manager to return NULL. Handle this case in Push Messaging by immediately rejecting the request instead. BUG=695418 Review-Url: https://codereview.chromium.org/2706243007 Cr-Commit-Position: refs/heads/master@{#452489} Committed: https://chromium.googlesource.com/chromium/src/+/ea60d1f2365d4715d25c4bdfb13c6749a2302a8f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M content/browser/push_messaging/push_messaging_manager.cc View 1 chunk +22 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Sami
lgtm
3 years, 10 months ago (2017-02-23 14:09:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706243007/1
3 years, 10 months ago (2017-02-23 14:10:25 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 15:15:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea60d1f2365d4715d25c4bdfb13c...

Powered by Google App Engine
This is Rietveld 408576698