Ship IndexedDB 2.0.

Ship IndexedDB 2.0.

BUG=693661, 644889
Review-Url: https://codereview.chromium.org/2706233005
Cr-Commit-Position: refs/heads/master@{#452742}
Committed: https://chromium.googlesource.com/chromium/src/+/905c681bf73399ab9c462ccf57e9f05640a92277

[pwnall, 2017-02-22 23:06:03]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 23:07:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 01:02:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 01:02:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pwnall, 2017-02-23 01:37:47]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[pwnall, 2017-02-23 01:38:14]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-02-23 01:38:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-02-23 01:39:55]

pwnall@chromium.org changed reviewers:
+ foolip@chromium.org, jsbell@chromium.org

[pwnall, 2017-02-23 01:39:56]

foolip: Can you please review the webexposed/ changes? 

jsbell: Please review everything else?

The I2S for these changes is at
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bmQjmh0-YB8/...

[foolip, 2017-02-23 02:30:54]

LGTM. If you think the risk of revert is low, you could just as well remove the
RuntimeEnabledFeature entirely. (The stable ones tend to build up over time.)

[commit-bot: I haz the power, 2017-02-23 03:22:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 03:22:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pwnall, 2017-02-23 03:49:31]

On 2017/02/23 02:30:54, foolip wrote:
> LGTM. If you think the risk of revert is low, you could just as well remove
the
> RuntimeEnabledFeature entirely. (The stable ones tend to build up over time.)

I filed http://crbug.com/695202 to track the removal. I'd like to do it in M59,
just to be on the safe side.

[foolip, 2017-02-23 03:51:58]

On 2017/02/23 03:49:31, pwnall wrote:
> On 2017/02/23 02:30:54, foolip wrote:
> > LGTM. If you think the risk of revert is low, you could just as well remove
> the
> > RuntimeEnabledFeature entirely. (The stable ones tend to build up over
time.)
> 
> I filed http://crbug.com/695202 to track the removal. I'd like to do it in
M59,
> just to be on the safe side.

Thanks!

[jsbell, 2017-02-23 18:41:07]

The storage/indexeddb/mozilla/cursors.html failure is unrelated, due to a CL
that's been reverted.

[jsbell, 2017-02-23 18:54:46]

Apparently we've ended up with platform specific virtual/stable expectations? :(

./platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
./platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt

[jsbell, 2017-02-23 18:56:16]

On 2017/02/23 18:54:46, jsbell wrote:
> Apparently we've ended up with platform specific virtual/stable expectations?
:(
> 
> ./platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
> ./platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt

At least those two are identical in tip-of-tree. So just copy the win/ one over
in this CL.

[jsbell, 2017-02-23 18:57:31]

otherwise lgtm

[foolip, 2017-02-23 19:42:08]

On 2017/02/23 18:54:46, jsbell wrote:
> Apparently we've ended up with platform specific virtual/stable expectations?
:(
> 
> ./platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
> ./platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt

Yes, this is very :(

When this change was made, there was a thread about some less terrible solution,
but it never happened, and now everyone is just :( instead.

[pwnall, 2017-02-23 23:02:59]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 23:03:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-02-23 23:12:11]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 23:12:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-02-23 23:13:53]

On 2017/02/23 18:56:16, jsbell wrote:
> On 2017/02/23 18:54:46, jsbell wrote:
> > Apparently we've ended up with platform specific virtual/stable
expectations?
> :(
> > 
> >
./platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
> >
./platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
> 
> At least those two are identical in tip-of-tree. So just copy the win/ one
over
> in this CL.

FWIW, I think they differ in WebBluetooth. I copied the Mac expectations from
the buildbot output.

$ cd third_party/WebKit/LayoutTests/
$ diff
./platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
./platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
257a258,328
> interface Bluetooth
>     attribute @@toStringTag
>     method constructor
>     method requestDevice
> interface BluetoothCharacteristicProperties
>     attribute @@toStringTag
>     getter authenticatedSignedWrites
>     getter broadcast
>     getter indicate
>     getter notify
>     getter read
>     getter reliableWrite
>     getter writableAuxiliaries
>     getter write
>     getter writeWithoutResponse
>     method constructor
> interface BluetoothDevice : EventTarget
>     attribute @@toStringTag
>     getter gatt
>     getter id
>     getter name
>     getter ongattserverdisconnected
>     method constructor
>     setter ongattserverdisconnected
> interface BluetoothRemoteGATTCharacteristic : EventTarget
>     attribute @@toStringTag
>     getter oncharacteristicvaluechanged
>     getter properties
>     getter service
>     getter uuid
>     getter value
>     method constructor
>     method getDescriptor
>     method getDescriptors
>     method readValue
>     method startNotifications
>     method stopNotifications
>     method writeValue
>     setter oncharacteristicvaluechanged
> interface BluetoothRemoteGATTDescriptor
>     attribute @@toStringTag
>     getter characteristic
>     getter uuid
>     getter value
>     method constructor
>     method readValue
>     method writeValue
> interface BluetoothRemoteGATTServer
>     attribute @@toStringTag
>     getter connected
>     getter device
>     method connect
>     method constructor
>     method disconnect
>     method getPrimaryService
>     method getPrimaryServices
> interface BluetoothRemoteGATTService
>     attribute @@toStringTag
>     getter device
>     getter isPrimary
>     getter uuid
>     method constructor
>     method getCharacteristic
>     method getCharacteristics
> interface BluetoothUUID
>     static method canonicalUUID
>     static method getCharacteristic
>     static method getDescriptor
>     static method getService
>     attribute @@toStringTag
>     method constructor
3452a3524
>     getter bluetooth

[commit-bot: I haz the power, 2017-02-24 00:58:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 00:58:11]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pwnall, 2017-02-24 02:22:23]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 02:22:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 03:38:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 03:38:27]

Dry run: This issue passed the CQ dry run.

[pwnall, 2017-02-24 03:38:45]

The CQ bit was checked by pwnall@chromium.org

[pwnall, 2017-02-24 03:38:45]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org,
foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2706233005/#ps60001
(title: "Mac expectations, take 2.")

[commit-bot: I haz the power, 2017-02-24 03:39:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 03:44:11]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487907525313830,
"parent_rev": "f5a506a917f583f5aa6e32231f8a7df563dfe170", "commit_rev":
"905c681bf73399ab9c462ccf57e9f05640a92277"}

[commit-bot: I haz the power, 2017-02-24 03:44:54]

Description was changed from

==========
Ship IndexedDB 2.0.

BUG=693661,644889
==========

to

==========
Ship IndexedDB 2.0.

BUG=693661,644889

Review-Url: https://codereview.chromium.org/2706233005
Cr-Commit-Position: refs/heads/master@{#452742}
Committed:
https://chromium.googlesource.com/chromium/src/+/905c681bf73399ab9c462ccf57e9...
==========

[commit-bot: I haz the power, 2017-02-24 03:44:55]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/905c681bf73399ab9c462ccf57e9...