Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2706213002: [heap] Unconditionally mark objects that undergo unsafe layout changes. (Closed)

Created:
3 years, 10 months ago by ulan
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Unconditionally mark objects that undergo unsafe layout changes. In the upcoming concurrent marking protocol the main thread will have to mark objects before performing unsafe layout change. This patch is an experiment for evaluating memory the impact of marking an object on layout change. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2706213002 Cr-Commit-Position: refs/heads/master@{#43351} Committed: https://chromium.googlesource.com/v8/v8/+/fa5304d1aad94d08fcc17c22e9ec03bf7ea4c295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/heap/heap.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
ulan
ptal
3 years, 10 months ago (2017-02-21 12:00:32 UTC) #3
Michael Lippautz
lgtm
3 years, 10 months ago (2017-02-21 17:31:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706213002/1
3 years, 10 months ago (2017-02-21 17:34:40 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 17:58:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fa5304d1aad94d08fcc17c22e9ec03bf7ea...

Powered by Google App Engine
This is Rietveld 408576698