FrameView: Remove redundant tree walk when unthrottling display:none frames

FrameView: Remove redundant tree walk when unthrottling display:none frames

When unthrottling display:none frames, there's no need to synchronously
unthrottle child frames because 1) we're about to walk the subtree
anyway and 2) to match Safari's behavior we actually want to keep
children of display:none frames throttled.

No functional changes, but added a new test to check how children of display:none
frames behave.

BUG=680925
TEST=https://jsfiddle.net/ohpkjn9p/2

Review-Url: https://codereview.chromium.org/2706193003
Cr-Commit-Position: refs/heads/master@{#452448}
Committed: https://chromium.googlesource.com/chromium/src/+/6d58fe57ab739bbc26291e04bce804721ba5b93d

[Sami, 2017-02-21 12:33:18]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[Sami, 2017-02-21 12:33:22]

Description was changed from

==========
FrameView: Remove redundant tree walk when unthrottling display:none frames

When unthrottling display:none frames, there's no need to synchronously
unthrottle child frames because 1) we're about to walk the subtree
anyway and 2) to match Safari's behavior we actually want to keep
children of display:none frames throttled.

No functional changes. Covered by existing tests, but added a new test
to check how children of display:none frames behave.

BUG=680925
TEST=https://jsfiddle.net/ohpkjn9p/2
==========

to

==========
FrameView: Remove redundant tree walk when unthrottling display:none frames

When unthrottling display:none frames, there's no need to synchronously
unthrottle child frames because 1) we're about to walk the subtree
anyway and 2) to match Safari's behavior we actually want to keep
children of display:none frames throttled.

No functional changes. Covered by existing tests, but added a new test
to check how children of display:none frames behave.

BUG=680925
TEST=https://jsfiddle.net/ohpkjn9p/2
==========

[Sami, 2017-02-21 12:33:22]

skyostil@chromium.org changed reviewers:
+ esprehn@chromium.org

[commit-bot: I haz the power, 2017-02-21 12:33:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2017-02-21 12:34:45]

Description was changed from

==========
FrameView: Remove redundant tree walk when unthrottling display:none frames

When unthrottling display:none frames, there's no need to synchronously
unthrottle child frames because 1) we're about to walk the subtree
anyway and 2) to match Safari's behavior we actually want to keep
children of display:none frames throttled.

No functional changes. Covered by existing tests, but added a new test
to check how children of display:none frames behave.

BUG=680925
TEST=https://jsfiddle.net/ohpkjn9p/2
==========

to

==========
FrameView: Remove redundant tree walk when unthrottling display:none frames

When unthrottling display:none frames, there's no need to synchronously
unthrottle child frames because 1) we're about to walk the subtree
anyway and 2) to match Safari's behavior we actually want to keep
children of display:none frames throttled.

No functional changes, but added a new test to check how children of
display:none
frames behave.

BUG=680925
TEST=https://jsfiddle.net/ohpkjn9p/2
==========

[commit-bot: I haz the power, 2017-02-21 16:18:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 16:18:28]

Dry run: This issue passed the CQ dry run.

[esprehn, 2017-02-21 19:41:36]

lgtm, we often use an enum instead of bools and comments too.

[Sami, 2017-02-22 17:56:50]

On 2017/02/21 19:41:36, esprehn wrote:
> lgtm, we often use an enum instead of bools and comments too.

Good idea, done.

[Sami, 2017-02-22 17:56:54]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2017-02-22 17:56:54]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2706193003/#ps20001
(title: "Enums ftw")

[commit-bot: I haz the power, 2017-02-22 17:57:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 18:17:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 18:17:35]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Sami, 2017-02-23 10:19:43]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2017-02-23 10:19:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 10:54:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487845183224650,
"parent_rev": "7322bbb0a42cfad6bf24e3bb157cb692381cda9f", "commit_rev":
"6d58fe57ab739bbc26291e04bce804721ba5b93d"}

[commit-bot: I haz the power, 2017-02-23 10:54:41]

Description was changed from

==========
FrameView: Remove redundant tree walk when unthrottling display:none frames

When unthrottling display:none frames, there's no need to synchronously
unthrottle child frames because 1) we're about to walk the subtree
anyway and 2) to match Safari's behavior we actually want to keep
children of display:none frames throttled.

No functional changes, but added a new test to check how children of
display:none
frames behave.

BUG=680925
TEST=https://jsfiddle.net/ohpkjn9p/2
==========

to

==========
FrameView: Remove redundant tree walk when unthrottling display:none frames

When unthrottling display:none frames, there's no need to synchronously
unthrottle child frames because 1) we're about to walk the subtree
anyway and 2) to match Safari's behavior we actually want to keep
children of display:none frames throttled.

No functional changes, but added a new test to check how children of
display:none
frames behave.

BUG=680925
TEST=https://jsfiddle.net/ohpkjn9p/2

Review-Url: https://codereview.chromium.org/2706193003
Cr-Commit-Position: refs/heads/master@{#452448}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d58fe57ab739bbc26291e04bce8...
==========

[commit-bot: I haz the power, 2017-02-23 10:54:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6d58fe57ab739bbc26291e04bce8...