Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/web/navigation/navigation_manager_impl.h

Issue 2706173003: change navigation initiation type default value to RENDERER_INITIATED (Closed)
Patch Set: Add NONE to NavigationInitiationType Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/navigation/navigation_item_impl.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/navigation_manager_impl.h
diff --git a/ios/web/navigation/navigation_manager_impl.h b/ios/web/navigation/navigation_manager_impl.h
index 11663bd8a2d402c64e304fc04f87860d430cc48d..3144df16490f8203741179fbff77202c1a681489 100644
--- a/ios/web/navigation/navigation_manager_impl.h
+++ b/ios/web/navigation/navigation_manager_impl.h
@@ -28,8 +28,10 @@ class SessionStorageBuilder;
// Defines the ways how a pending navigation can be initiated.
enum class NavigationInitiationType {
+ NONE = 1,
Eugene But (OOO till 7-30) 2017/02/21 23:00:40 This can be 0, because it's a good default value.
Eugene But (OOO till 7-30) 2017/02/21 23:00:40 Needs comments
liaoyuke 2017/02/21 23:07:47 Done.
liaoyuke 2017/02/21 23:07:47 Done.
+
// Navigation was initiated by actual user action.
- USER_INITIATED = 1,
+ USER_INITIATED,
// Navigation was initiated by renderer. Examples of renderer-initiated
// navigations include:
« no previous file with comments | « ios/web/navigation/navigation_item_impl.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698