Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Side by Side Diff: ios/web/navigation/navigation_manager_impl.h

Issue 2706173003: change navigation initiation type default value to RENDERER_INITIATED (Closed)
Patch Set: Add NONE to NavigationInitiationType Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/web/navigation/navigation_item_impl.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_ 5 #ifndef IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_
6 #define IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_ 6 #define IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 10 matching lines...) Expand all
21 namespace web { 21 namespace web {
22 class BrowserState; 22 class BrowserState;
23 class NavigationItem; 23 class NavigationItem;
24 struct Referrer; 24 struct Referrer;
25 class NavigationManagerDelegate; 25 class NavigationManagerDelegate;
26 class NavigationManagerFacadeDelegate; 26 class NavigationManagerFacadeDelegate;
27 class SessionStorageBuilder; 27 class SessionStorageBuilder;
28 28
29 // Defines the ways how a pending navigation can be initiated. 29 // Defines the ways how a pending navigation can be initiated.
30 enum class NavigationInitiationType { 30 enum class NavigationInitiationType {
31 NONE = 1,
Eugene But (OOO till 7-30) 2017/02/21 23:00:40 This can be 0, because it's a good default value.
Eugene But (OOO till 7-30) 2017/02/21 23:00:40 Needs comments
liaoyuke 2017/02/21 23:07:47 Done.
liaoyuke 2017/02/21 23:07:47 Done.
32
31 // Navigation was initiated by actual user action. 33 // Navigation was initiated by actual user action.
32 USER_INITIATED = 1, 34 USER_INITIATED,
33 35
34 // Navigation was initiated by renderer. Examples of renderer-initiated 36 // Navigation was initiated by renderer. Examples of renderer-initiated
35 // navigations include: 37 // navigations include:
36 // * <a> link click 38 // * <a> link click
37 // * changing window.location.href 39 // * changing window.location.href
38 // * redirect via the <meta http-equiv="refresh"> tag 40 // * redirect via the <meta http-equiv="refresh"> tag
39 // * using window.history.pushState 41 // * using window.history.pushState
40 RENDERER_INITIATED, 42 RENDERER_INITIATED,
41 }; 43 };
42 44
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 // List of transient url rewriters added by |AddTransientURLRewriter()|. 199 // List of transient url rewriters added by |AddTransientURLRewriter()|.
198 std::unique_ptr<std::vector<BrowserURLRewriter::URLRewriter>> 200 std::unique_ptr<std::vector<BrowserURLRewriter::URLRewriter>>
199 transient_url_rewriters_; 201 transient_url_rewriters_;
200 202
201 DISALLOW_COPY_AND_ASSIGN(NavigationManagerImpl); 203 DISALLOW_COPY_AND_ASSIGN(NavigationManagerImpl);
202 }; 204 };
203 205
204 } // namespace web 206 } // namespace web
205 207
206 #endif // IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_ 208 #endif // IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_
OLDNEW
« no previous file with comments | « ios/web/navigation/navigation_item_impl.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698