Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 270613006: GN documentation updates. (Closed)

Created:
6 years, 7 months ago by brettw
Modified:
6 years, 7 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

GN documentation updates. Mark the "copy" target as a target function so it appears in the correct section of "gn help". Use get_target_outputs() in the template example, since you should generall do this instead of process_file_template. Update docs for process_file_template to state that you should use get_target_outputs if possible. R=cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269793

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M tools/gn/function_process_file_template.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tools/gn/function_template.cc View 2 chunks +14 lines, -11 lines 0 comments Download
M tools/gn/functions.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
brettw
6 years, 7 months ago (2014-05-07 20:15:55 UTC) #1
cjhopman
lgtm https://codereview.chromium.org/270613006/diff/20001/tools/gn/functions.cc File tools/gn/functions.cc (right): https://codereview.chromium.org/270613006/diff/20001/tools/gn/functions.cc#newcode650 tools/gn/functions.cc:650: INSERT_FUNCTION(Copy, true) nit: Move this up into the ...
6 years, 7 months ago (2014-05-07 20:19:18 UTC) #2
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 7 months ago (2014-05-07 23:03:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/270613006/40001
6 years, 7 months ago (2014-05-07 23:06:35 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 07:37:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 20:27:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/13560)
6 years, 7 months ago (2014-05-08 20:27:56 UTC) #7
brettw
6 years, 7 months ago (2014-05-12 16:19:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r269793 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698