GN documentation updates.

tools/gn/function_template.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/functions.h"
 
 #include "tools/gn/parse_tree.h"
 #include "tools/gn/scope.h"
 #include "tools/gn/template.h"
 #include "tools/gn/value.h"
@@ skipping 65 matching lines @@
     "    # Be nice and help callers debug problems by checking that the\n"
     "    # variables the template requires are defined. This gives a nice\n"
     "    # message rather than giving the user an error about an\n"
     "    # undefined variable in the file defining the template\n"
     "    #\n"
     "    # You can also use defined() to give default values to variables\n"
     "    # unspecified by the invoker.\n"
     "    assert(defined(invoker.sources),\n"
     "           \"Need sources in $target_name listing the idl files.\")\n"
     "\n"
-    "    # Define a variable containing a source expansion\n"
-    "    # (see \"gn help source_expansion\") that maps input files to\n"
-    "    # output files. It is used in both targets below.\n"
-    "    filter = [ \"$target_gen_dir/{{source_name_part}}.cc\",\n"
-    "               \"$target_gen_dir/{{source_name_part}}.h\" ]\n"
+    "    # Name of the intermediate target that does the code gen. This must\n"
+    "    # incorporate the target name so it's unique across template\n"
+    "    # instantiations.\n"
+    "    code_gen_target_name = target_name + \"_code_gen\"\n"
     "\n"
     "    # Intermediate target to convert IDL to C source. Note that the name\n"
     "    # is based on the name the invoker of the template specified. This\n"
     "    # way, each time the template is invoked we get a unique\n"
     "    # intermediate action name (since all target names are in the global\n"
     "    # scope).\n"
-    "    action_foreach(\"${target_name}_code_gen\") {\n"
+    "    action_foreach(code_gen_target_name) {\n"
     "      # Access the scope defined by the invoker via the implicit\n"
     "      # \"invoker\" variable.\n"
     "      sources = invoker.sources\n"
     "\n"
     "      # Note that we need an absolute path for our script file name.\n"
     "      # The current directory when executing this code will be that of\n"
     "      # the invoker (this is why we can use the \"sources\" directly\n"
     "      # above without having to rebase all of the paths). But if we need\n"
     "      # to reference a script relative to the template file, we'll need\n"
     "      # to use an absolute path instead.\n"
     "      script = \"//tools/idl/idl_code_generator.py\"\n"
-    "      outputs = filter  # Variable from above.\n"
+    "\n"
+    "      # Tell GN how to expand output names given the sources.\n"
+    "      # See \"gn help source_expansion\" for more.\n"
+    "      outputs = [ \"$target_gen_dir/{{source_name_part}}.cc\",\n"
+    "                  \"$target_gen_dir/{{source_name_part}}.h\" ]\n"
     "    }\n"
     "\n"
     "    # Name the source set the same as the template invocation so\n"
     "    # instancing this template produces something that other targets\n"
     "    # can link to in their deps.\n"
     "    source_set(target_name) {\n"
-    "      # Generates the list of sources.\n"
-    "      # See \"gn help process_file_template\"\n"
-    "      sources = process_file_template(invoker.sources, filter)\n"
+    "      # Generates the list of sources, we get these from the\n"
+    "      # action_foreach above.\n"
+    "      sources = get_target_outputs(\":$code_gen_target_name\")\n"
     "\n"
     "      # This target depends on the files produced by the above code gen\n"
     "      # target.\n"
-    "      deps = [ \":${target_name}_code_gen\" ]\n"
+    "      deps = [ \":$code_gen_target_name\" ]\n"
     "    }\n"
     "  }\n"
     "\n"
     "Example of invoking the resulting template:\n"
     "\n"
     "  # This calls the template code above, defining target_name to be\n"
     "  # \"foo_idl_files\" and \"invoker\" to be the set of stuff defined in\n"
     "  # the curly brackets.\n"
     "  my_idl(\"foo_idl_files\") {\n"
     "    # Goes into the template as \"invoker.sources\".\n"
@@ skipping 32 matching lines @@
     err->AppendSubErr(Err(existing_template->GetDefinitionRange(),
                           "Previous definition."));
     return Value();
   }
 
   scope->AddTemplate(template_name, new Template(scope, function));
   return Value();
 }
 
 }  // namespace functions