Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2706093002: Media Capabilities: update Blink implementation and WPT to match latest spec changes. (Closed)

Created:
3 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 10 months ago
Reviewers:
chcunningham
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Capabilities: update Blink implementation and WPT to match latest spec changes. Changes are: - s/type/contentType/ in {Audio/Video}Configuration; - add [SameObject] to partial Navigator interfaces; - rename "MediaSource" enum entry to "media-source". This is also adding more tests for checks of valid MediaConfiguration.type when running query(). BUG=690380 R=chcunningham@chromium.org Review-Url: https://codereview.chromium.org/2706093002 Cr-Commit-Position: refs/heads/master@{#451669} Committed: https://chromium.googlesource.com/chromium/src/+/e751d794815701533203812a5ea101aa16689a27

Patch Set 1 #

Patch Set 2 : with manifest update #

Total comments: 2

Patch Set 3 : review comments #

Patch Set 4 : update MANIFEST.json #

Messages

Total messages: 22 (13 generated)
mlamouri (slow - plz ping)
PTAL :)
3 years, 10 months ago (2017-02-20 16:12:43 UTC) #5
chcunningham
lgtm https://codereview.chromium.org/2706093002/diff/20001/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/query.html File third_party/WebKit/LayoutTests/external/wpt/media-capabilities/query.html (right): https://codereview.chromium.org/2706093002/diff/20001/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/query.html#newcode10 third_party/WebKit/LayoutTests/external/wpt/media-capabilities/query.html:10: contentType: 'video/webm', When we have real plumbing, this ...
3 years, 10 months ago (2017-02-20 18:03:30 UTC) #6
mlamouri (slow - plz ping)
Thanks. Comments applied.
3 years, 10 months ago (2017-02-20 18:24:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706093002/40001
3 years, 10 months ago (2017-02-20 18:24:35 UTC) #10
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-20 20:13:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706093002/60001
3 years, 10 months ago (2017-02-20 20:49:13 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/18506)
3 years, 10 months ago (2017-02-20 22:29:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706093002/60001
3 years, 10 months ago (2017-02-20 22:30:30 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 23:13:36 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e751d794815701533203812a5ea1...

Powered by Google App Engine
This is Rietveld 408576698