Add publisher information on ContentSuggestionsArticles

Add publisher information on ContentSuggestionsArticles

BUG=694220
Review-Url: https://codereview.chromium.org/2706083002
Cr-Commit-Position: refs/heads/master@{#451720}
Committed: https://chromium.googlesource.com/chromium/src/+/ba2021e717c9e8370d54fce780b8eb0245c57e94

[gambard, 2017-02-20 14:48:19]

gambard@chromium.org changed reviewers:
+ jif@chromium.org

[gambard, 2017-02-20 14:48:20]

PTAL.

[jif, 2017-02-20 16:01:00]

lgtm with nits

https://codereview.chromium.org/2706083002/diff/1/ios/chrome/browser/ui/conte...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h
(right):

https://codereview.chromium.org/2706083002/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h:45:
date:(const base::Time&)publishDate;
base::Time is basically just a int64_t, so passing it as a reference (which is
also 64 bits) is wasteful.

That being said, most functions in Chromium use "const base::Time&" to pass time
around.
Up to you to decide if you want to fast/small code, or consistent code.

https://codereview.chromium.org/2706083002/diff/1/ios/chrome/browser/ui/conte...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm
(right):

https://codereview.chromium.org/2706083002/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm:56:
stringByTrimmingCharactersInSet:[NSCharacterSet
IMO stringByTrimmingCharactersInSet should be done before initWithType:.. is
called.

https://codereview.chromium.org/2706083002/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm:143:
[NSString stringWithFormat:@"%@ - %@.", publisherName, dateString];
not RTL friendly :'(

[gambard, 2017-02-21 08:49:46]

Thanks!

https://codereview.chromium.org/2706083002/diff/1/ios/chrome/browser/ui/conte...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h
(right):

https://codereview.chromium.org/2706083002/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h:45:
date:(const base::Time&)publishDate;
On 2017/02/20 16:01:00, jif wrote:
> base::Time is basically just a int64_t, so passing it as a reference (which is
> also 64 bits) is wasteful.
> 
> That being said, most functions in Chromium use "const base::Time&" to pass
time
> around.
> Up to you to decide if you want to fast/small code, or consistent code.

Done.

https://codereview.chromium.org/2706083002/diff/1/ios/chrome/browser/ui/conte...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm
(right):

https://codereview.chromium.org/2706083002/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm:56:
stringByTrimmingCharactersInSet:[NSCharacterSet
On 2017/02/20 16:01:00, jif wrote:
> IMO stringByTrimmingCharactersInSet should be done before initWithType:.. is
> called.

This is a typo. I removed it.

https://codereview.chromium.org/2706083002/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm:143:
[NSString stringWithFormat:@"%@ - %@.", publisherName, dateString];
On 2017/02/20 16:01:00, jif wrote:
> not RTL friendly :'(

I added a TODO.

[gambard, 2017-02-21 08:49:49]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-02-21 08:49:50]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org
Link to the patchset: https://codereview.chromium.org/2706083002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2017-02-21 08:50:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 08:57:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 08:57:21]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[gambard, 2017-02-21 10:01:46]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-02-21 10:01:46]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org
Link to the patchset: https://codereview.chromium.org/2706083002/#ps40001
(title: "Fix compilation")

[commit-bot: I haz the power, 2017-02-21 10:02:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 10:13:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487671306002690,
"parent_rev": "c8ff75bcb4213239787068128437f9829a2f0de8", "commit_rev":
"ba2021e717c9e8370d54fce780b8eb0245c57e94"}

[commit-bot: I haz the power, 2017-02-21 10:14:08]

Description was changed from

==========
Add publisher information on ContentSuggestionsArticles

BUG=694220
==========

to

==========
Add publisher information on ContentSuggestionsArticles

BUG=694220

Review-Url: https://codereview.chromium.org/2706083002
Cr-Commit-Position: refs/heads/master@{#451720}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba2021e717c9e8370d54fce780b8...
==========

[commit-bot: I haz the power, 2017-02-21 10:14:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ba2021e717c9e8370d54fce780b8...