Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2706063005: Temporarily expose "backKeyPressed" (Closed)

Created:
3 years, 10 months ago by gone
Modified:
3 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily expose "backKeyPressed" Allows subclasses to handle the back key, as well. BUG=None Review-Url: https://codereview.chromium.org/2706063005 Cr-Commit-Position: refs/heads/master@{#452179} Committed: https://chromium.googlesource.com/chromium/src/+/4d2ef6f0772e9f78fa3088d8dccccc0692aec3f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
gone
3 years, 10 months ago (2017-02-22 00:52:42 UTC) #2
Ted C
lgtm
3 years, 10 months ago (2017-02-22 04:58:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706063005/1
3 years, 10 months ago (2017-02-22 17:49:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/215712)
3 years, 10 months ago (2017-02-22 18:13:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706063005/1
3 years, 10 months ago (2017-02-22 19:09:15 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 20:12:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d2ef6f0772e9f78fa3088d8dccc...

Powered by Google App Engine
This is Rietveld 408576698