Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2706033011: Expand FrameSeleciton::rootEditableElement() to increase chances of hoisting update layout (Closed)

Created:
3 years, 10 months ago by yosin_UTC9
Modified:
3 years, 10 months ago
Reviewers:
tkent, yoichio
CC:
blink-reviews, chromium-reviews, dtapuska+blinkwatch_chromium.org, Navid Zolghadr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand FrameSeleciton::rootEditableElement() to increase chances of hoisting update layout This patch expands |FrameSeleciton::rootEditableElement()| to increase chance of hoisting update layout. Note: This is mechanical change to replace |selection().rootEditableElement()| by |selection().computeVisibleSelectionInDOMTreeDeprecated().rootEditableElement()| Following patch will remove deprecated version. This patch is apart of expanding expensive member functions in |FrameSelection|: - rootEditableElement() - hasEditableStyle() - isContentEditable() - isContentRichlyEditable() - getSelectionType() - base() - extent() - start() - end() - isNone() - isCaret() - isRange() BUG=694360 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2706033011 Cr-Commit-Position: refs/heads/master@{#451967} Committed: https://chromium.googlesource.com/chromium/src/+/44432291616740a6a8ae87b6460aa2b5be812018

Patch Set 1 : 2017-02-22T12:50:05 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL Changes in core/editing/ and core/input/
3 years, 10 months ago (2017-02-22 06:53:55 UTC) #5
tkent
lgtm
3 years, 10 months ago (2017-02-22 07:36:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706033011/1
3 years, 10 months ago (2017-02-22 08:22:35 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 10:09:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/44432291616740a6a8ae87b6460a...

Powered by Google App Engine
This is Rietveld 408576698