Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2706033009: Limit optimized LayoutBlockFlowLine width computation to 8bit (Closed)

Created:
3 years, 10 months ago by eae
Modified:
3 years, 9 months ago
Reviewers:
kojii
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Limit optimized LayoutBlockFlowLine width computation to 8bit Limit the use of the optimized LayoutBlockFlowLine width implementation to 8-bit text as it isn't guaranteed to work correctly for 16-bit text. BUG=692014 R=kojii@chromium.org Review-Url: https://codereview.chromium.org/2706033009 Cr-Commit-Position: refs/heads/master@{#456271} Committed: https://chromium.googlesource.com/chromium/src/+/8683b364d376b33bed4cbfe6b46d2c39411b05cd

Patch Set 1 #

Patch Set 2 : Rebase w/HEAD #

Patch Set 3 : w/Baselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6244 lines, -96 lines) Patch
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/select/menulist-appearance-rtl-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/drawBidiText-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/select/menulist-appearance-rtl-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/drawBidiText-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/writing-mode/border-vertical-lr-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/menulist-appearance-rtl-expected.png View 1 2 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/menulist-appearance-rtl-expected.txt View 1 2 9 chunks +40 lines, -40 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/drawBidiText-expected.txt View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt View 1 2 1 chunk +2910 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/border-vertical-lr-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/border-vertical-lr-expected.txt View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/japanese-lr-selection-expected.txt View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/japanese-lr-text-expected.txt View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/japanese-rl-selection-expected.txt View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/japanese-rl-text-expected.txt View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/select/menulist-appearance-rtl-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/drawBidiText-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/select/menulist-appearance-rtl-expected.png View 1 2 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/select/menulist-appearance-rtl-expected.txt View 1 2 9 chunks +40 lines, -40 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/drawBidiText-expected.txt View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt View 1 2 1 chunk +2910 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/border-vertical-lr-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/border-vertical-lr-expected.txt View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/japanese-lr-selection-expected.txt View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/japanese-lr-text-expected.txt View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/japanese-rl-selection-expected.txt View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/japanese-rl-text-expected.txt View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/forms/select/menulist-appearance-rtl-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
eae
3 years, 10 months ago (2017-02-21 23:34:03 UTC) #1
kojii
lgtm
3 years, 10 months ago (2017-02-22 05:05:36 UTC) #6
kojii
looks like some rebaselines needed.
3 years, 10 months ago (2017-02-22 05:06:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706033009/40001
3 years, 9 months ago (2017-03-11 02:08:37 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/8683b364d376b33bed4cbfe6b46d2c39411b05cd
3 years, 9 months ago (2017-03-11 03:29:00 UTC) #17
klausw
3 years, 9 months ago (2017-03-11 06:06:12 UTC) #18
Message was sent while issue was closed.
On 2017/03/11 03:29:00, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
>
https://chromium.googlesource.com/chromium/src/+/8683b364d376b33bed4cbfe6b46d...

FYI, I think this broke WebKit layout tests for Mac10.12:

https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Mac10.12/91

unexpected_failures:
fast/writing-mode/japanese-rl-selection.html
fast/writing-mode/border-vertical-lr.html
fast/writing-mode/japanese-rl-text.html
fast/writing-mode/Kusa-Makura-background-canvas.html
fast/writing-mode/japanese-lr-text.html
fast/writing-mode/japanese-lr-selection.html

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_12/...

(I was keeping an eye on the queue due to my change being in the same batch.)

Powered by Google App Engine
This is Rietveld 408576698