[ObjC ARC] Converts ios/chrome/app/application_delegate:test_support to ARC.

[ObjC ARC] Converts ios/chrome/app/application_delegate:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2706033003
Cr-Commit-Position: refs/heads/master@{#451754}
Committed: https://chromium.googlesource.com/chromium/src/+/9c58d92ce27ae171141b775599361cfb769a692e

[stkhapugin, 2017-02-20 15:41:33]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 15:41:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-02-20 16:50:04]

stkhapugin@chromium.org changed reviewers:
+ sdefresne@chromium.org

[stkhapugin, 2017-02-20 16:50:05]

ptal

[commit-bot: I haz the power, 2017-02-20 16:59:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 16:59:46]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-02-21 09:42:40]

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
File ios/chrome/app/application_delegate/fake_startup_information.mm (right):

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/fake_startup_information.mm:15:
AppStartupParameters* _startupParameters;
I think you can now @synthesize this property too and remove custom
setter/getter.

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/fake_startup_information.mm:26: -
(AppStartupParameters*)startupParameters {
Remove if you use @synthesize.

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/fake_startup_information.mm:30: -
(void)setStartupParameters:(AppStartupParameters*)startupParameters {
Remove if you use @synthesize.

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
File ios/chrome/app/application_delegate/mock_tab_opener.h (right):

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/mock_tab_opener.h:21: @property(weak,
nonatomic, readonly) void (^completionBlock)(void);
This is incoherent with the code the property was a ScopedBlock, so not weak but
strong.

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
File ios/chrome/app/application_delegate/mock_tab_opener.mm (right):

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/mock_tab_opener.mm:18: ProceduralBlock
_completionBlock;
I think you can @synthesize this property now.

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/mock_tab_opener.mm:41: - (void
(^)())completionBlock {
Remove if you use @synthesize.

[stkhapugin, 2017-02-21 12:53:02]

Done, ptal

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
File ios/chrome/app/application_delegate/fake_startup_information.mm (right):

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/fake_startup_information.mm:15:
AppStartupParameters* _startupParameters;
On 2017/02/21 09:42:40, sdefresne wrote:
> I think you can now @synthesize this property too and remove custom
> setter/getter.

Done.

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/fake_startup_information.mm:26: -
(AppStartupParameters*)startupParameters {
On 2017/02/21 09:42:40, sdefresne wrote:
> Remove if you use @synthesize.

Done.

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/fake_startup_information.mm:30: -
(void)setStartupParameters:(AppStartupParameters*)startupParameters {
On 2017/02/21 09:42:40, sdefresne wrote:
> Remove if you use @synthesize.

Done.

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
File ios/chrome/app/application_delegate/mock_tab_opener.h (right):

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/mock_tab_opener.h:21: @property(weak,
nonatomic, readonly) void (^completionBlock)(void);
On 2017/02/21 09:42:40, sdefresne wrote:
> This is incoherent with the code the property was a ScopedBlock, so not weak
but
> strong.

Done.

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
File ios/chrome/app/application_delegate/mock_tab_opener.mm (right):

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/mock_tab_opener.mm:18: ProceduralBlock
_completionBlock;
On 2017/02/21 09:42:40, sdefresne wrote:
> I think you can @synthesize this property now.

Done.

https://codereview.chromium.org/2706033003/diff/1/ios/chrome/app/application_...
ios/chrome/app/application_delegate/mock_tab_opener.mm:41: - (void
(^)())completionBlock {
On 2017/02/21 09:42:40, sdefresne wrote:
> Remove if you use @synthesize.

Done.

[sdefresne, 2017-02-21 12:55:35]

lgtm

[stkhapugin, 2017-02-21 13:08:30]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-02-21 13:08:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 14:26:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487682510252520,
"parent_rev": "2d8378bf293f5a0a0dbec1f5c2436fe7eaa51d3b", "commit_rev":
"9c58d92ce27ae171141b775599361cfb769a692e"}

[commit-bot: I haz the power, 2017-02-21 14:26:49]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/app/application_delegate:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/app/application_delegate:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2706033003
Cr-Commit-Position: refs/heads/master@{#451754}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c58d92ce27ae171141b77559936...
==========

[commit-bot: I haz the power, 2017-02-21 14:26:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9c58d92ce27ae171141b77559936...