Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2706023003: Expand FrameSeleciton::isContentRichlyEditable() to increase chances of hoisting update layout (Closed)

Created:
3 years, 10 months ago by yosin_UTC9
Modified:
3 years, 10 months ago
Reviewers:
tkent, yoichio
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand FrameSeleciton::isContentRichlyEditable() This patch expands |FrameSeleciton::isContentRichlyEditable()| to increase chance of hoisting update layout. Note: This is mechanical change to replace |selection().isContentRichlyEditable()| by |selection().computeVisibleSelectionInDOMTreeDeprecated().isContentRichlyEditable()| Following patch will remove deprecated version. This patch is part of expanding expensive member functions in |FrameSelection|: - rootEditableElement() - hasEditableStyle() - isContentEditable() - isContentRichlyEditable() - base() - extent() - start() - end() - isNone() - isCaret() - isRange() BUG=694360 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2706023003 Cr-Commit-Position: refs/heads/master@{#451707} Committed: https://chromium.googlesource.com/chromium/src/+/1d4a8832edffa6fb5a0d4e217008fb959b8c9fe6

Patch Set 1 : 2017-02-21T11:28:21 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
yosin_UTC9
PTAL
3 years, 10 months ago (2017-02-21 03:16:45 UTC) #6
tkent
lgtm
3 years, 10 months ago (2017-02-21 03:29:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706023003/1
3 years, 10 months ago (2017-02-21 03:31:12 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 05:34:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1d4a8832edffa6fb5a0d4e217008...

Powered by Google App Engine
This is Rietveld 408576698