Added support for self.origin in Window and WorkerGlobalScope

Added support for self.origin in Window and WorkerGlobalScope

Added origin to the interface files
Added firefox tests for frames into the wpt 
Created and added tests for workers into the wpt
Intent to ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/oPGdc9lqpg8/gSjBah0YCAAJ

BUG=690195, 694444
R=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2706013002
Cr-Commit-Position: refs/heads/master@{#454747}
Committed: https://chromium.googlesource.com/chromium/src/+/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7

[andypaicu, 2017-02-20 09:24:34]

Description was changed from

==========
Added support for self.origin in Window and WorkerGlobalScope

BUG=690195
==========

to

==========
Added support for self.origin in Window and WorkerGlobalScope

Added origin to the interface files
Added firefox tests for frames into the wpt 
Created and added tests for workers into the wpt

BUG=690195
R=mkwst@chromium.org
==========

[andypaicu, 2017-02-20 10:00:04]

andypaicu@chromium.org changed reviewers:
+ mkwst@chromium.org

[andypaicu, 2017-02-20 10:00:05]

Second time's the charm

[Mike West, 2017-02-20 10:11:22]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 10:11:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mike West, 2017-02-20 10:12:19]

On 2017/02/20 at 10:00:05, andypaicu wrote:
> Second time's the charm

(As an aside, you should have try access now, so it's helpful to run `git cl
try` locally after you run `git cl upload`. That will kick off a dry run through
the CQ, which helps us evaluate whether or not the patch applies, compiles, and
passes tests. :) )

[tkent, 2017-02-20 10:48:00]

tkent@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2017-02-20 10:48:01]

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/external/wpt/html/dom/self-origin.any.js
(right):

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/html/dom/self-origin.any.js:1: "use
strict";
*.any.js doesn't work in Chromium repo, right?

The test location looks wrong. In html/, directories should match to the
specification structure.
So, we should put the test to a directory
html/webappsapis/the-windoworworkerglobalscope-mixin/.

[Mike West, 2017-02-20 11:13:08]

On 2017/02/20 at 10:48:01, tkent wrote:
>
https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
> File third_party/WebKit/LayoutTests/external/wpt/html/dom/self-origin.any.js
(right):
> 
>
https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/external/wpt/html/dom/self-origin.any.js:1:
"use strict";
> *.any.js doesn't work in Chromium repo, right?

Does `.any.js` have special behavior in wpt? It doesn't look like it requires
any.

> The test location looks wrong. In html/, directories should match to the
specification structure.
> So, we should put the test to a directory
html/webappsapis/the-windoworworkerglobalscope-mixin/.

Andy's copying tests that Mozilla upstreamed (see
https://github.com/w3c/web-platform-tests/tree/master/html/dom/self-origin.su...,
for example), but that hasn't yet been imported into our repository. I don't
think it's worth arguing about the location, given that it's already here.

I'm sure he'd be happy to move it off to the better location in a subsequent
patch if you feel strongly about it. :)

[commit-bot: I haz the power, 2017-02-20 11:26:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 11:26:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mike West, 2017-02-20 12:21:06]

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html
(right):

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html:1:
<!DOCTYPE html>
That said, I think this is new: Andy, perhaps you could move this to the
directory tkent@ suggested?

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html:6:
<div id="log"></div>
I don't think you're using this.

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html:8:
function assertOrigin_Worker(workerSource, expectedOrigin, testName) {
Pick either CamelCase or hacker_case, but please don't mix them. :)

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html:37:
// Test blow url workers
s/blow/blob/

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/workers/WorkerGlobalScope.idl (right):

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/workers/WorkerGlobalScope.idl:67: // Intending to
deprecate document.origin so use this in workers instead
I'd drop this comment, but point to the definition in HTML instead because it's
not actually defined on WorkerGlobalScope and Window, but on
https://html.spec.whatwg.org/#windoworworkerglobalscope-mixin. We don't
implement that interface in Blink, but we probably should.

[andypaicu, 2017-02-20 13:09:28]

mkwst@ made some changes and answered some others

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html
(right):

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html:1:
<!DOCTYPE html>
On 2017/02/20 at 12:21:06, Mike West (sloooooow) wrote:
> That said, I think this is new: Andy, perhaps you could move this to the
directory tkent@ suggested?

tkent@ mentioned tests under html/ and this is under workers/. Should I still
move it?

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html:6:
<div id="log"></div>
On 2017/02/20 at 12:21:06, Mike West (sloooooow) wrote:
> I don't think you're using this.

There was something on the specs about having a container in the page for
prettier results.
"If you wish the HTML page into which your tests are being run to render results
in a nice 
and convenient table, you should include an HTML element with ID log where you
would like 
those results to appear. See the bottom of this document for an example."

I can take it out if it's not relevant. It does not seem to work as in the
example anyway.

[tkent, 2017-02-20 14:20:19]

On 2017/02/20 at 11:13:08, mkwst wrote:
> On 2017/02/20 at 10:48:01, tkent wrote:
> >
https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
> > File third_party/WebKit/LayoutTests/external/wpt/html/dom/self-origin.any.js
(right):
> > 
> >
https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
> > third_party/WebKit/LayoutTests/external/wpt/html/dom/self-origin.any.js:1:
"use strict";
> > *.any.js doesn't work in Chromium repo, right?
> 
> Does `.any.js` have special behavior in wpt? It doesn't look like it requires
any.

It's multi-global tests. 
http://web-platform-tests.org/writing-tests/testharness.html#multi-global-tests
Our bug: crbug.com/653514

> 
> > The test location looks wrong. In html/, directories should match to the
specification structure.
> > So, we should put the test to a directory
html/webappsapis/the-windoworworkerglobalscope-mixin/.
> 
> Andy's copying tests that Mozilla upstreamed (see
https://github.com/w3c/web-platform-tests/tree/master/html/dom/self-origin.su...,
for example), but that hasn't yet been imported into our repository. I don't
think it's worth arguing about the location, given that it's already here.
> 
> I'm sure he'd be happy to move it off to the better location in a subsequent
patch if you feel strongly about it. :)

oh, I see.

[tkent, 2017-02-20 14:22:47]

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html
(right):

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html:1:
<!DOCTYPE html>
On 2017/02/20 at 13:09:27, andypaicu wrote:
> On 2017/02/20 at 12:21:06, Mike West (sloooooow) wrote:
> > That said, I think this is new: Andy, perhaps you could move this to the
directory tkent@ suggested?
> 
> tkent@ mentioned tests under html/ and this is under workers/. Should I still
move it?

The worker specification, https://w3c.github.io/workers/, doesn't look to define
self.origin.  If it's correct, we should not add the test to wpt/workers/.

[andypaicu, 2017-02-20 14:25:48]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 14:26:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[andypaicu, 2017-02-20 14:31:11]

On 2017/02/20 at 14:22:47, tkent wrote:
>
https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html
(right):
> 
>
https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html:1:
<!DOCTYPE html>
> On 2017/02/20 at 13:09:27, andypaicu wrote:
> > On 2017/02/20 at 12:21:06, Mike West (sloooooow) wrote:
> > > That said, I think this is new: Andy, perhaps you could move this to the
directory tkent@ suggested?
> > 
> > tkent@ mentioned tests under html/ and this is under workers/. Should I
still move it?
> 
> The worker specification, https://w3c.github.io/workers/, doesn't look to
define self.origin.  If it's correct, we should not add the test to
wpt/workers/.

Yes, self.origin is defined under WindowOrWorkerGlobalScope so it applies to
both WorkerGlobalScope and Window
(https://html.spec.whatwg.org/#windoworworkerglobalscope-mixin).
Going by that I think it's reasonable to add the worker side of the test under
wpt/workers.

[Mike West, 2017-02-20 14:32:21]

On 2017/02/20 at 14:22:47, tkent wrote:
>
https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html
(right):
> 
>
https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html:1:
<!DOCTYPE html>
> On 2017/02/20 at 13:09:27, andypaicu wrote:
> > On 2017/02/20 at 12:21:06, Mike West (sloooooow) wrote:
> > > That said, I think this is new: Andy, perhaps you could move this to the
directory tkent@ suggested?
> > 
> > tkent@ mentioned tests under html/ and this is under workers/. Should I
still move it?
> 
> The worker specification, https://w3c.github.io/workers/, doesn't look to
define self.origin.  If it's correct, we should not add the test to
wpt/workers/.

The property is defined in the WindowOrWorkerGlobalScope mixin:
https://html.spec.whatwg.org/#windoworworkerglobalscope-mixin. As you note,
tkent@, we should put new tests for that interface in
html/webappsapis/the-windoworworkerglobalscope-mixin/.

Also, looking at the mixin, I think this patch missed the `[Replaceable]`
attribute in the IDL files. Mind adding that back in?

[andypaicu, 2017-02-20 15:27:34]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 15:27:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 17:13:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 17:13:42]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mike West, 2017-02-21 06:54:37]

https://codereview.chromium.org/2706013002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/websocket/send-onmessage-origin.html
(right):

https://codereview.chromium.org/2706013002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/websocket/send-onmessage-origin.html:24:
var wsOrigin = "";
Hrm. You shouldn't have to do this; this is more or less exactly what
`[Replaceable]` is supposed to handle:
https://heycam.github.io/webidl/#Replaceable. Let's take a look together today.

https://codereview.chromium.org/2706013002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
(right):

https://codereview.chromium.org/2706013002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt:2171:
[Worker]     getter origin
Adding `[Replaceable]` gives you a setter as well; looks like you'll need to
rebaseline these again.

[andypaicu, 2017-02-21 09:23:39]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 09:24:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[andypaicu, 2017-02-21 09:25:39]

On 2017/02/20 at 14:22:47, tkent wrote:
>
https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html
(right):
> 
>
https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html:1:
<!DOCTYPE html>
> On 2017/02/20 at 13:09:27, andypaicu wrote:
> > On 2017/02/20 at 12:21:06, Mike West (sloooooow) wrote:
> > > That said, I think this is new: Andy, perhaps you could move this to the
directory tkent@ suggested?
> > 
> > tkent@ mentioned tests under html/ and this is under workers/. Should I
still move it?
> 
> The worker specification, https://w3c.github.io/workers/, doesn't look to
define self.origin.  If it's correct, we should not add the test to
wpt/workers/.

Test moved to html/webappsapis/the-windoworworkerglobalscope-mixin/

[andypaicu, 2017-02-21 09:37:29]

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html
(right):

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html:8:
function assertOrigin_Worker(workerSource, expectedOrigin, testName) {
On 2017/02/20 at 12:21:06, Mike West (sloooooow) wrote:
> Pick either CamelCase or hacker_case, but please don't mix them. :)

Done

https://codereview.chromium.org/2706013002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/workers/Worker_Self_Origin.html:37:
// Test blow url workers
On 2017/02/20 at 12:21:05, Mike West (sloooooow) wrote:
> s/blow/blob/

Done

https://codereview.chromium.org/2706013002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/websocket/send-onmessage-origin.html
(right):

https://codereview.chromium.org/2706013002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/websocket/send-onmessage-origin.html:24:
var wsOrigin = "";
On 2017/02/21 at 06:54:36, Mike West (sloooooow) wrote:
> Hrm. You shouldn't have to do this; this is more or less exactly what
`[Replaceable]` is supposed to handle:
https://heycam.github.io/webidl/#Replaceable. Let's take a look together today.

Raised https://bugs.chromium.org/p/chromium/issues/detail?id=694444 as discussed
in person. For now left the variable to be different then 'origin'.

https://codereview.chromium.org/2706013002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
(right):

https://codereview.chromium.org/2706013002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt:2171:
[Worker]     getter origin
On 2017/02/21 at 06:54:36, Mike West (sloooooow) wrote:
> Adding `[Replaceable]` gives you a setter as well; looks like you'll need to
rebaseline these again.

Done

[commit-bot: I haz the power, 2017-02-21 10:44:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 10:44:20]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[andypaicu, 2017-02-21 13:58:25]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 13:58:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mike West, 2017-02-21 14:20:05]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2017-02-21 14:20:06]

LGTM.

Please add a link to the intent thread to the CL description, and ask either
jochen@ or tkent@ to stamp the webexposed changes since you got approval on
blink-dev@. :)

https://codereview.chromium.org/2706013002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/websocket/handshake-fail-by-maxlength.html
(right):

https://codereview.chromium.org/2706013002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/websocket/handshake-fail-by-maxlength.html:16:
var wsOrigin;
Can you add the new bug number to the `BUG=` line in the CL description?

[andypaicu, 2017-02-21 14:23:22]

Description was changed from

==========
Added support for self.origin in Window and WorkerGlobalScope

Added origin to the interface files
Added firefox tests for frames into the wpt 
Created and added tests for workers into the wpt

BUG=690195
R=mkwst@chromium.org
==========

to

==========
Added support for self.origin in Window and WorkerGlobalScope

Added origin to the interface files
Added firefox tests for frames into the wpt 
Created and added tests for workers into the wpt

BUG=690195,694444
R=mkwst@chromium.org
==========

[andypaicu, 2017-02-21 14:24:25]

Description was changed from

==========
Added support for self.origin in Window and WorkerGlobalScope

Added origin to the interface files
Added firefox tests for frames into the wpt 
Created and added tests for workers into the wpt

BUG=690195,694444
R=mkwst@chromium.org
==========

to

==========
Added support for self.origin in Window and WorkerGlobalScope

Added origin to the interface files
Added firefox tests for frames into the wpt 
Created and added tests for workers into the wpt
Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/oPGdc9lqpg8/gS...

BUG=690195,694444
R=mkwst@chromium.org
==========

[andypaicu, 2017-02-21 14:25:57]

https://codereview.chromium.org/2706013002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/websocket/handshake-fail-by-maxlength.html
(right):

https://codereview.chromium.org/2706013002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/websocket/handshake-fail-by-maxlength.html:16:
var wsOrigin;
On 2017/02/21 at 14:20:06, Mike West (sloooooow) wrote:
> Can you add the new bug number to the `BUG=` line in the CL description?

Done

[commit-bot: I haz the power, 2017-02-21 16:23:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 16:23:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2017-02-22 02:25:12]

lgtm

[andypaicu, 2017-02-22 07:54:03]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 07:55:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-02-22 09:06:50]

lgtm

[commit-bot: I haz the power, 2017-02-22 09:44:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 09:45:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[andypaicu, 2017-02-24 09:24:42]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 09:25:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 10:15:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 10:15:13]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[andypaicu, 2017-02-28 16:09:48]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 16:10:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 18:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 18:04:28]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[andypaicu, 2017-03-01 02:32:05]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 02:33:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 04:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 04:04:12]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[andypaicu, 2017-03-01 22:43:12]

The CQ bit was checked by andypaicu@chromium.org

[andypaicu, 2017-03-01 22:43:12]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
mkwst@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2706013002/#ps180001
(title: "Fix layout tests again")

[commit-bot: I haz the power, 2017-03-01 22:44:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 00:22:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 00:22:53]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[andypaicu, 2017-03-02 01:36:32]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 01:37:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 03:41:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 03:41:08]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[andypaicu, 2017-03-02 16:56:50]

rbyers@
Hi Rick,

It seems that
external/wpt/mediacapture-streams/MediaStreamTrack-end-manual.https.html is
failing in my patch. The reason seems to be that when it was changed to be a
manual test it was not added in TestExpectations. But because the manifest was
not updated either but the test name was changed, it resulted in the test not
being run. 
Now I've added some other tests and regenerated the manifest so it starts
running the test again and since it's not in TestExpectations it's timing out
and failing the patch.

[andypaicu, 2017-03-04 00:30:02]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-04 00:30:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 01:48:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 01:48:53]

Dry run: This issue passed the CQ dry run.

[andypaicu, 2017-03-04 01:55:15]

The CQ bit was checked by andypaicu@chromium.org

[andypaicu, 2017-03-04 01:55:15]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
jochen@chromium.org, mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2706013002/#ps220001
(title: "rebase-update after manifest.json changes")

[commit-bot: I haz the power, 2017-03-04 01:55:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 02:00:18]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1488592515144900,
"parent_rev": "f5a29c6561e3820a5e71e03c85eb7597b797bfd7", "commit_rev":
"f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7"}

[commit-bot: I haz the power, 2017-03-04 02:00:58]

Description was changed from

==========
Added support for self.origin in Window and WorkerGlobalScope

Added origin to the interface files
Added firefox tests for frames into the wpt 
Created and added tests for workers into the wpt
Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/oPGdc9lqpg8/gS...

BUG=690195,694444
R=mkwst@chromium.org
==========

to

==========
Added support for self.origin in Window and WorkerGlobalScope

Added origin to the interface files
Added firefox tests for frames into the wpt 
Created and added tests for workers into the wpt
Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/oPGdc9lqpg8/gS...

BUG=690195,694444
R=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2706013002
Cr-Commit-Position: refs/heads/master@{#454747}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5a130d1fb31ab5ab19a0c85edd6...
==========

[commit-bot: I haz the power, 2017-03-04 02:01:00]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/f5a130d1fb31ab5ab19a0c85edd6...