Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2706003002: Get rid of unused functions SelectionAdjuster::adjustSelectionIn{DOM,Flat}Tree (Closed)

Created:
3 years, 10 months ago by yosin_UTC9
Modified:
3 years, 10 months ago
Reviewers:
tkent, yoichio
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of unused functions SelectionAdjuster::adjustSelectionIn{DOM,Flat}Tree This patch gets rid of unused function |adjustSelectionIn{DOM,Flat}Tree| from |SelectionAdjuster| class for improving code helath. BUG=693915 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2706003002 Cr-Commit-Position: refs/heads/master@{#451677} Committed: https://chromium.googlesource.com/chromium/src/+/6301d4c08fc112c8e72b75c608ff20c4cc4b1721

Patch Set 1 : 2017-02-20T18:17:58 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -151 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionAdjuster.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp View 1 chunk +0 lines, -94 lines 0 comments Download
D third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yosin_UTC9
PTAL
3 years, 10 months ago (2017-02-20 09:35:46 UTC) #6
tkent
lgtm
3 years, 10 months ago (2017-02-20 22:57:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706003002/1
3 years, 10 months ago (2017-02-20 22:57:32 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 00:39:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6301d4c08fc112c8e72b75c608ff...

Powered by Google App Engine
This is Rietveld 408576698