Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 27060: Make basic bits of chrome/test/automation build on Linux. (Closed)

Created:
11 years, 10 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
ananta, brettw, jam
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make basic bits of chrome/test/automation build on Linux.

Patch Set 1 #

Total comments: 2

Patch Set 2 : use base::kNoTimeout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -91 lines) Patch
M chrome/test/automation/automation.scons View 2 chunks +12 lines, -3 lines 0 comments Download
M chrome/test/automation/automation_handle_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_proxy.h View 1 7 chunks +22 lines, -6 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 21 chunks +45 lines, -70 lines 0 comments Download
M chrome/test/automation/browser_proxy.h View 1 4 chunks +14 lines, -0 lines 0 comments Download
M chrome/test/automation/browser_proxy.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/automation/tab_proxy.h View 1 4 chunks +13 lines, -0 lines 0 comments Download
M chrome/test/automation/tab_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/window_proxy.h View 3 chunks +9 lines, -1 line 0 comments Download
M chrome/test/automation/window_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
11 years, 10 months ago (2009-02-23 21:19:37 UTC) #1
ananta
Adding Brett as he may have an opinion on the right way to achieve this. ...
11 years, 10 months ago (2009-02-24 02:28:37 UTC) #2
brettw
Ben has a patch to do the app modal dialog more portably: http://codereview.chromium.org/27080
11 years, 10 months ago (2009-02-24 18:39:09 UTC) #3
brettw
I think the timer stuff is OK. I didn't review the rest very closely, I'll ...
11 years, 10 months ago (2009-02-24 18:50:49 UTC) #4
ananta
11 years, 10 months ago (2009-02-24 19:52:48 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698