AppModalDialogQueue shouldn't depend on views.

AppModalDialogQueue shouldn't depend on views.

Add a simple test, too.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10320

[brettw, 2009-02-24 17:50:48]

http://codereview.chromium.org/27080/diff/1/3
File chrome/browser/app_modal_dialog_delegate.h (right):

http://codereview.chromium.org/27080/diff/1/3#newcode17
Line 17: virtual views::DialogDelegate* GetDialogDelegate() = 0;
Do you have a plan for improving this?

http://codereview.chromium.org/27080/diff/1/9
File chrome/browser/app_modal_dialog_queue_unittest.cc (right):

http://codereview.chromium.org/27080/diff/1/9#newcode12
Line 12: class AppModalDialogQueueTest : public testing::Test {
This class definition is unnecessary, just delete it.

http://codereview.chromium.org/27080/diff/1/9#newcode29
Line 29: }
Should have "// namespace" here.

http://codereview.chromium.org/27080/diff/1/11
File chrome/browser/jsmessage_box_handler_win.cc (right):

http://codereview.chromium.org/27080/diff/1/11#newcode96
Line 96: JavascriptMessageBoxHandler::GetTestingInterface() {
I wouldn't indent this line at all.

[Ben Goodger (Google), 2009-02-24 22:48:58]

On 2009/02/24 17:50:48, brettw wrote:
> http://codereview.chromium.org/27080/diff/1/3
> File chrome/browser/app_modal_dialog_delegate.h (right):
> 
> http://codereview.chromium.org/27080/diff/1/3#newcode17
> Line 17: virtual views::DialogDelegate* GetDialogDelegate() = 0;
> Do you have a plan for improving this?

Not at this time. I'll wait until after all the porting stuff settles down and
it becomes clear what we want to do with automation.

Snapshot updated.

[brettw, 2009-02-24 23:00:39]

LGTM