Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2705963002: (Android) Removing deprecated org.apache.http.* classes (Closed)

Created:
3 years, 10 months ago by marcin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Android) Removing deprecated org.apache.http.* classes BUG=694333 Review-Url: https://codereview.chromium.org/2705963002 Cr-Commit-Position: refs/heads/master@{#453664} Committed: https://chromium.googlesource.com/chromium/src/+/b359508647ab409f07b071dd3237050f7305c1c7

Patch Set 1 : Removing deprecated org.apache.http.* classes #

Patch Set 2 : 2nd version - cleanups/fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -199 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnFormResubmissionTest.java View 2 chunks +2 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java View 1 4 chunks +15 lines, -24 lines 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java View 1 9 chunks +152 lines, -172 lines 0 comments Download

Messages

Total messages: 91 (84 generated)
marcin
Hi, Please provide your initial comments (in mean time I will test it deeply).
3 years, 10 months ago (2017-02-20 21:15:54 UTC) #5
Torne
android_webview LGTM
3 years, 10 months ago (2017-02-21 11:58:34 UTC) #8
Paweł Hajdan Jr.
LGTM
3 years, 10 months ago (2017-02-22 17:15:55 UTC) #9
marcin
Hi, Patch is good for publishing. I had to make some changes especially in web ...
3 years, 9 months ago (2017-02-27 23:26:25 UTC) #79
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705963002/440001
3 years, 9 months ago (2017-02-28 19:22:18 UTC) #87
marcin
Committed after some additional testing
3 years, 9 months ago (2017-02-28 19:22:42 UTC) #88
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 19:29:51 UTC) #91
Message was sent while issue was closed.
Committed patchset #2 (id:440001) as
https://chromium.googlesource.com/chromium/src/+/b359508647ab409f07b071dd3237...

Powered by Google App Engine
This is Rietveld 408576698