|
|
Chromium Code Reviews
Description(Android) Removing deprecated org.apache.http.* classes
BUG=694333
Review-Url: https://codereview.chromium.org/2705963002
Cr-Commit-Position: refs/heads/master@{#453664}
Committed: https://chromium.googlesource.com/chromium/src/+/b359508647ab409f07b071dd3237050f7305c1c7
Patch Set 1 : Removing deprecated org.apache.http.* classes #Patch Set 2 : 2nd version - cleanups/fixes #
Messages
Total messages: 91 (84 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== X X X X X X BUG= ========== to ========== (Android) Removing deprecated org.apache.http.* classes BUG= ==========
Description was changed from ========== (Android) Removing deprecated org.apache.http.* classes BUG= ========== to ========== (Android) Removing deprecated org.apache.http.* classes BUG=694333 ==========
marcin@mwiacek.com changed reviewers: + phajdan.jr@chromium.org, torne@chromium.org
Hi, Please provide your initial comments (in mean time I will test it deeply).
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
android_webview LGTM
LGTM
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:100001) has been deleted
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
Patchset #3 (id:120001) has been deleted
Patchset #3 (id:140001) has been deleted
Patchset #3 (id:160001) has been deleted
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:180001) has been deleted
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:200001) has been deleted
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:220001) has been deleted
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:240001) has been deleted
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:260001) has been deleted
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Patchset #3 (id:280001) has been deleted
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:300001) has been deleted
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:80001) has been deleted
Patchset #2 (id:320001) has been deleted
Patchset #2 (id:340001) has been deleted
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Patchset #2 (id:360001) has been deleted
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
Patchset #2 (id:380001) has been deleted
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
Patchset #2 (id:400001) has been deleted
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Hi, Patch is good for publishing. I had to make some changes especially in web server file (when compare to first version). Paweł, could you kindly/shortly look on it please ? Thank you, Marcin
The CQ bit was checked by marcin@mwiacek.com to run a CQ dry run
Patchset #2 (id:420001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by marcin@mwiacek.com
The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org, phajdan.jr@chromium.org Link to the patchset: https://codereview.chromium.org/2705963002/#ps440001 (title: "2nd version - cleanups/fixes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Committed after some additional testing
CQ is committing da patch.
Bot data: {"patchset_id": 440001, "attempt_start_ts": 1488309706193850,
"parent_rev": "a1d9b2dc55999f3e2cb00e861116c2baeb398560", "commit_rev":
"b359508647ab409f07b071dd3237050f7305c1c7"}
Message was sent while issue was closed.
Description was changed from ========== (Android) Removing deprecated org.apache.http.* classes BUG=694333 ========== to ========== (Android) Removing deprecated org.apache.http.* classes BUG=694333 Review-Url: https://codereview.chromium.org/2705963002 Cr-Commit-Position: refs/heads/master@{#453664} Committed: https://chromium.googlesource.com/chromium/src/+/b359508647ab409f07b071dd3237... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:440001) as https://chromium.googlesource.com/chromium/src/+/b359508647ab409f07b071dd3237... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
