Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2705933002: Check that a valid RawVarData has been created before calling a function on it (Closed)

Created:
3 years, 10 months ago by raymes
Modified:
3 years, 10 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check that a valid RawVarData has been created before calling a function on it Currently the PP_Var type that is deserialized from an incoming IPC is invalid, RawVarData::Create will return a nullptr which we will try to call a function on. Instead we should just fail to deserialize the entire message in that case. BUG=693007 Review-Url: https://codereview.chromium.org/2705933002 Cr-Commit-Position: refs/heads/master@{#451541} Committed: https://chromium.googlesource.com/chromium/src/+/d0dfa19bdd289d481228e9da89b6ffb0040a9aaa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ppapi/proxy/raw_var_data.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
raymes
3 years, 10 months ago (2017-02-20 00:29:58 UTC) #4
bbudge
Nice. LGTM
3 years, 10 months ago (2017-02-20 01:04:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705933002/1
3 years, 10 months ago (2017-02-20 01:20:42 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 01:58:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0dfa19bdd289d481228e9da89b6...

Powered by Google App Engine
This is Rietveld 408576698