Do not guess UTF8 encoding
Makes the text encoding detector return false if the detected
encoding is UTF8. UTF8 auto-detection can allow/encourage web publishers
to neglect proper encoding labelling and rely on browser-side encoding
detection. This CL helps prevent that.
BUG=691985
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2697213002
Cr-Commit-Position: refs/heads/master@{#451194}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2705913002
Cr-Commit-Position: refs/branch-heads/2987@{#617}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/50dce2837d94d319260d6ff269c09514d0691fb0
Note: 2 layout test files modified in the master branch don't seem to be present ...
3 years, 10 months ago
(2017-02-20 00:22:51 UTC)
#6
Note: 2 layout test files modified in the master branch don't seem to be present
in the release branch:
LayoutTests/external/wpt/html/syntax/parsing-html-fragments/the-input-byte-stream-015.html
LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-vertical.html
Removed them in this CL.
tkent
lgtm
3 years, 10 months ago
(2017-02-20 00:26:06 UTC)
#7
sky@chromium.org: Please review changes in chrome/browser (cherrypicking in to the release M57)
3 years, 10 months ago
(2017-02-20 00:34:13 UTC)
#9
sky@chromium.org: Please review changes in chrome/browser (cherrypicking in to
the release M57)
sky
Generally merges are TBR. LGTM
3 years, 10 months ago
(2017-02-21 17:15:41 UTC)
#10
Generally merges are TBR. LGTM
Jinsuk Kim
Description was changed from ========== Do not guess UTF8 encoding Makes the text encoding detector ...
3 years, 10 months ago
(2017-02-21 19:21:29 UTC)
#11
Description was changed from
==========
Do not guess UTF8 encoding
Makes the text encoding detector return false if the detected
encoding is UTF8. UTF8 auto-detection can allow/encourage web publishers
to neglect proper encoding labelling and rely on browser-side encoding
detection. This CL helps prevent that.
BUG=691985
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2697213002
Cr-Commit-Position: refs/heads/master@{#451194}
==========
to
==========
Do not guess UTF8 encoding
Makes the text encoding detector return false if the detected
encoding is UTF8. UTF8 auto-detection can allow/encourage web publishers
to neglect proper encoding labelling and rely on browser-side encoding
detection. This CL helps prevent that.
BUG=691985
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2697213002
Cr-Commit-Position: refs/heads/master@{#451194}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
Jinsuk Kim
The CQ bit was checked by jinsukkim@chromium.org
3 years, 10 months ago
(2017-02-21 19:23:29 UTC)
#12
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487705009358940, "parent_rev": "2a7a93cf5bfa2d3db02105fb7153fd8dd5dc4a74", "commit_rev": "50dce2837d94d319260d6ff269c09514d0691fb0"}
3 years, 10 months ago
(2017-02-21 19:29:24 UTC)
#15
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487705009358940,
"parent_rev": "2a7a93cf5bfa2d3db02105fb7153fd8dd5dc4a74", "commit_rev":
"50dce2837d94d319260d6ff269c09514d0691fb0"}
commit-bot: I haz the power
Description was changed from ========== Do not guess UTF8 encoding Makes the text encoding detector ...
3 years, 10 months ago
(2017-02-21 19:30:07 UTC)
#16
Message was sent while issue was closed.
Description was changed from
==========
Do not guess UTF8 encoding
Makes the text encoding detector return false if the detected
encoding is UTF8. UTF8 auto-detection can allow/encourage web publishers
to neglect proper encoding labelling and rely on browser-side encoding
detection. This CL helps prevent that.
BUG=691985
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2697213002
Cr-Commit-Position: refs/heads/master@{#451194}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========
to
==========
Do not guess UTF8 encoding
Makes the text encoding detector return false if the detected
encoding is UTF8. UTF8 auto-detection can allow/encourage web publishers
to neglect proper encoding labelling and rely on browser-side encoding
detection. This CL helps prevent that.
BUG=691985
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2697213002
Cr-Commit-Position: refs/heads/master@{#451194}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2705913002
Cr-Commit-Position: refs/branch-heads/2987@{#617}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/50dce2837d94d319260d6ff269c0...
==========
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/50dce2837d94d319260d6ff269c09514d0691fb0
3 years, 10 months ago
(2017-02-21 19:30:08 UTC)
#17
Issue 2705913002: Do not guess UTF8 encoding
(Closed)
Created 3 years, 10 months ago by Jinsuk Kim
Modified 3 years, 10 months ago
Reviewers: tkent, sky
Base URL:
Comments: 0