Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2705903002: Restore conflicting layout test suppression (Closed)

Created:
3 years, 10 months ago by robertphillips
Modified:
3 years, 10 months ago
Reviewers:
f(malita), reed2, reed1
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore conflicting layout test suppression This suppression conflicted with those in https://codereview.chromium.org/2702703002/ (Add suppressions for upcoming Skia DEPS roll). This CL cannot land until the rebaselines requested in https://codereview.chromium.org/2706693003/ (AutoRebaseline Layout tests suppressed for Skia roll) have landed. BUG=693510 Review-Url: https://codereview.chromium.org/2705903002 Cr-Commit-Position: refs/heads/master@{#451540} Committed: https://chromium.googlesource.com/chromium/src/+/813de3871ce80bbb54755202264fd00dba9d42f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
robertphillips
3 years, 10 months ago (2017-02-19 16:43:40 UTC) #3
f(malita)
lgtm
3 years, 10 months ago (2017-02-19 22:25:08 UTC) #4
robertphillips
The auto-rebaselining has occurred so this should be good to go.
3 years, 10 months ago (2017-02-19 23:50:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705903002/1
3 years, 10 months ago (2017-02-20 01:34:34 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 01:40:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/813de3871ce80bbb54755202264f...

Powered by Google App Engine
This is Rietveld 408576698