Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2705873002: Add gbm to wheezy, jessie sysroots. (Closed)

Created:
3 years, 10 months ago by fjhenigman
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Needed to build a new ANGLE backend. BUG=angleproject:1423 Review-Url: https://codereview.chromium.org/2705873002 Cr-Commit-Position: refs/heads/master@{#452341} Committed: https://chromium.googlesource.com/chromium/src/+/25bb6d0b96e76f7e87a62f15370213867ed902a2

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add gbm to wheezy, jessie sysroots. #

Patch Set 3 : Add gbm to sysroots. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -24 lines) Patch
M build/linux/sysroot_scripts/packagelist.jessie.amd64 View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.arm View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.arm64 View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.i386 View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.mipsel View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.precise.amd64 View 1 2 3 chunks +9 lines, -7 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.trusty.arm View 1 2 3 chunks +19 lines, -17 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.amd64 View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.arm View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.i386 View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.mipsel View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-jessie.sh View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-precise.sh View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-trusty.sh View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-wheezy.sh View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Jamie Madill
looks OK to me, but not an owner. I added some reviewers for the sysroot ...
3 years, 10 months ago (2017-02-22 20:46:30 UTC) #2
fjhenigman
On 2017/02/22 20:46:30, Jamie Madill wrote: > looks OK to me, but not an owner. ...
3 years, 10 months ago (2017-02-22 20:48:34 UTC) #3
fjhenigman
I've only done wheezy and jessie because I don't know that it will work on ...
3 years, 10 months ago (2017-02-22 21:02:10 UTC) #5
fjhenigman
On 2017/02/22 21:02:10, fjhenigman wrote: > I've only done wheezy and jessie because I don't ...
3 years, 10 months ago (2017-02-22 23:59:20 UTC) #6
Dirk Pranke
-mmoss, -phajdan.jr, +thomasanderson ... Tom, can you take a look at this and help them ...
3 years, 10 months ago (2017-02-23 00:00:52 UTC) #8
Dirk Pranke
lgtm / deferring to thomasanderson@, to be clear.
3 years, 10 months ago (2017-02-23 00:04:21 UTC) #9
Tom (Use chromium acct)
Can you also add gbm to the precise and trusty sysroots? After that, you can ...
3 years, 10 months ago (2017-02-23 00:38:10 UTC) #10
fjhenigman
On 2017/02/23 00:38:10, Tom Anderson wrote: > Can you also add gbm to the precise ...
3 years, 10 months ago (2017-02-23 01:08:06 UTC) #11
Tom (Use chromium acct)
On 2017/02/23 01:08:06, fjhenigman wrote: > On 2017/02/23 00:38:10, Tom Anderson wrote: > > Can ...
3 years, 10 months ago (2017-02-23 01:09:25 UTC) #12
fjhenigman
On 2017/02/23 01:09:25, Tom Anderson wrote: > On 2017/02/23 01:08:06, fjhenigman wrote: > > On ...
3 years, 10 months ago (2017-02-23 01:24:47 UTC) #13
Tom (Use chromium acct)
On 2017/02/23 01:24:47, fjhenigman wrote: > On 2017/02/23 01:09:25, Tom Anderson wrote: > > On ...
3 years, 10 months ago (2017-02-23 01:31:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705873002/40001
3 years, 10 months ago (2017-02-23 01:35:40 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 01:54:24 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/25bb6d0b96e76f7e87a62f153702...

Powered by Google App Engine
This is Rietveld 408576698