InfoBarContainerView: Redraws infobars on a native theme change

InfoBarContainerView: Redraws infobars on a native theme change

This CL fixes a bug where infobars would be left with the previous
theme's border color when the system theme changes.  Previously, you'd
have to resize the browser to get the infobar to redraw correctly.

R=pkasting@chromium.org
BUG=693815
Review-Url: https://codereview.chromium.org/2705763002
Cr-Commit-Position: refs/heads/master@{#451443}
Committed: https://chromium.googlesource.com/chromium/src/+/9a1fcb408d1540dbf44a44755352ba12cc5f6a06

[Tom (Use chromium acct), 2017-02-18 01:13:20]

Description was changed from

==========
InfoBarContainerView: Redraw infobars on a native theme change

This CL fixes a bug where infobars would be left with the previous
theme's border color when the system theme changes.  Previously, you'd
have to resize the browser to get the infobar to redraw correctly.

R=pkasting@chromium.org
==========

to

==========
InfoBarContainerView: Redraws infobars on a native theme change

This CL fixes a bug where infobars would be left with the previous
theme's border color when the system theme changes.  Previously, you'd
have to resize the browser to get the infobar to redraw correctly.

R=pkasting@chromium.org
==========

[Tom (Use chromium acct), 2017-02-18 01:21:43]

Description was changed from

==========
InfoBarContainerView: Redraws infobars on a native theme change

This CL fixes a bug where infobars would be left with the previous
theme's border color when the system theme changes.  Previously, you'd
have to resize the browser to get the infobar to redraw correctly.

R=pkasting@chromium.org
==========

to

==========
InfoBarContainerView: Redraws infobars on a native theme change

This CL fixes a bug where infobars would be left with the previous
theme's border color when the system theme changes.  Previously, you'd
have to resize the browser to get the infobar to redraw correctly.

R=pkasting@chromium.org
BUG=693815
==========

[Tom (Use chromium acct), 2017-02-18 01:21:53]

pkasting ptal

[Peter Kasting, 2017-02-18 01:26:20]

LGTM

https://codereview.chromium.org/2705763002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/infobars/infobar_container_view.cc (right):

https://codereview.chromium.org/2705763002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/infobars/infobar_container_view.cc:138: for (int i = 0;
i < child_count(); ++i)
Nit: Might want a comment noting what bit of code/functionality requires a
repaint on native theme change.

https://codereview.chromium.org/2705763002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/infobars/infobar_container_view.h (right):

https://codereview.chromium.org/2705763002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/infobars/infobar_container_view.h:35: // views::View:
Nit: This class doesn't directly subclass View, place this in the appropriate
location in the AccessiblePaneView overrides list

[Tom (Use chromium acct), 2017-02-18 01:54:13]

https://codereview.chromium.org/2705763002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/infobars/infobar_container_view.cc (right):

https://codereview.chromium.org/2705763002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/infobars/infobar_container_view.cc:138: for (int i = 0;
i < child_count(); ++i)
On 2017/02/18 01:26:20, Peter Kasting wrote:
> Nit: Might want a comment noting what bit of code/functionality requires a
> repaint on native theme change.

Done.

https://codereview.chromium.org/2705763002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/infobars/infobar_container_view.h (right):

https://codereview.chromium.org/2705763002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/infobars/infobar_container_view.h:35: // views::View:
On 2017/02/18 01:26:20, Peter Kasting wrote:
> Nit: This class doesn't directly subclass View, place this in the appropriate
> location in the AccessiblePaneView overrides list

Done.

[Tom (Use chromium acct), 2017-02-18 01:54:17]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2017-02-18 01:54:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2705763002/#ps40001
(title: "Address pkasting@'s comments")

[commit-bot: I haz the power, 2017-02-18 01:55:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 03:58:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 03:58:21]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Tom (Use chromium acct), 2017-02-18 07:36:00]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-02-18 07:36:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 07:41:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487403360203100,
"parent_rev": "d0a10f5b8c0fa1312be688ca3a68cf240ab7f874", "commit_rev":
"9a1fcb408d1540dbf44a44755352ba12cc5f6a06"}

[commit-bot: I haz the power, 2017-02-18 07:42:34]

Description was changed from

==========
InfoBarContainerView: Redraws infobars on a native theme change

This CL fixes a bug where infobars would be left with the previous
theme's border color when the system theme changes.  Previously, you'd
have to resize the browser to get the infobar to redraw correctly.

R=pkasting@chromium.org
BUG=693815
==========

to

==========
InfoBarContainerView: Redraws infobars on a native theme change

This CL fixes a bug where infobars would be left with the previous
theme's border color when the system theme changes.  Previously, you'd
have to resize the browser to get the infobar to redraw correctly.

R=pkasting@chromium.org
BUG=693815

Review-Url: https://codereview.chromium.org/2705763002
Cr-Commit-Position: refs/heads/master@{#451443}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a1fcb408d1540dbf44a44755352...
==========

[commit-bot: I haz the power, 2017-02-18 07:42:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9a1fcb408d1540dbf44a44755352...